Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop excluding ClusterMachineApproverDown from firing check #24138

Merged
merged 1 commit into from Nov 20, 2019
Merged

Stop excluding ClusterMachineApproverDown from firing check #24138

merged 1 commit into from Nov 20, 2019

Conversation

enxebre
Copy link
Member

@enxebre enxebre commented Nov 12, 2019

No description provided.

@enxebre
Copy link
Member Author

enxebre commented Nov 13, 2019

/retest

1 similar comment
@enxebre
Copy link
Member Author

enxebre commented Nov 13, 2019

/retest

bison
bison approved these changes Nov 13, 2019
View reviewed changes
Copy link

@bison bison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2019
@enxebre
Copy link
Member Author

enxebre commented Nov 19, 2019

/retest

@deads2k
Copy link
Contributor

deads2k commented Nov 19, 2019

/approve
/retest

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bison, deads2k, enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2019
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit c6489fd into openshift:master Nov 20, 2019
deads2k added a commit to deads2k/origin that referenced this pull request Dec 13, 2019
@deads2k
Revert "Merge pull request openshift#24138 from enxebre/machine-appro…
ec87047 
…ver-alert"

This reverts commit c6489fd, reversing
changes made to ff958ca.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bison bison bison approved these changes

Assignees

@bison bison

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@enxebre @deads2k @openshift-ci-robot @openshift-bot @bison @openshift-merge-robot