Bug 1776226: KubeAPI server doesn't accept large patch requests #24196
Conversation
|
@p0lyn0mial: This pull request references Bugzilla bug 1776226, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/valid-bug
|
/assign @mfojtik |
| @@ -109,12 +125,12 @@ func TestMaxResourceSize(t *testing.T) { | |||
| t.Errorf("expected success or bad request err, got %v", err) | |||
| } | |||
| }) | |||
| t.Run("ApplyPatchType should handle a patch just under the max limit", func(t *testing.T) { | |||
There was a problem hiding this comment.
almost a clean pick, I had to remove tests for ApplyPatchType because they don't apply here
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mfojtik, p0lyn0mial The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/hold I need to investigate the failing integration step. |
openshift-ci-robot
added
the
do-not-merge/hold
|
/retest |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
@p0lyn0mial: All pull requests linked via external trackers have merged. Bugzilla bug 1776226 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.