Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1776351: Restore UPSTREAM from #24159: Expose a simple journald shim on the kubelet logs endpoint #24201

Conversation

sttts
Copy link
Contributor

@sttts sttts commented Nov 25, 2019

Part of #24195.

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 25, 2019
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 25, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: soltysh, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@soltysh
Copy link
Member

soltysh commented Nov 25, 2019

/retitle Bug 1763807: Restore UPSTREAM from #24159: Expose a simple journald shim on the kubelet logs endpoint

@openshift-ci-robot openshift-ci-robot changed the title Restore UPSTREAM from #24159: Expose a simple journald shim on the kubelet logs endpoint Bug 1763807: Restore UPSTREAM from #24159: Expose a simple journald shim on the kubelet logs endpoint Nov 25, 2019
@openshift-ci-robot
Copy link

@sttts: This pull request references Bugzilla bug 1763807, which is invalid:

  • expected the bug to target the "4.4.0" release, but it targets "4.3.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1763807: Restore UPSTREAM from #24159: Expose a simple journald shim on the kubelet logs endpoint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Nov 25, 2019
@soltysh
Copy link
Member

soltysh commented Nov 25, 2019

/retitle Restore UPSTREAM from #24159: Expose a simple journald shim on the kubelet logs endpoint

@openshift-ci-robot openshift-ci-robot changed the title Bug 1763807: Restore UPSTREAM from #24159: Expose a simple journald shim on the kubelet logs endpoint Restore UPSTREAM from #24159: Expose a simple journald shim on the kubelet logs endpoint Nov 25, 2019
@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Nov 25, 2019
@openshift-ci-robot
Copy link

@sttts: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Restore UPSTREAM from #24159: Expose a simple journald shim on the kubelet logs endpoint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sttts sttts changed the title Restore UPSTREAM from #24159: Expose a simple journald shim on the kubelet logs endpoint Bug 1776351: Restore UPSTREAM from #24159: Expose a simple journald shim on the kubelet logs endpoint Nov 25, 2019
@sttts sttts changed the title Bug 1776351: Restore UPSTREAM from #24159: Expose a simple journald shim on the kubelet logs endpoint Bug 1763807: Restore UPSTREAM from #24159: Expose a simple journald shim on the kubelet logs endpoint Nov 25, 2019
@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Nov 25, 2019
@openshift-ci-robot
Copy link

@sttts: This pull request references Bugzilla bug 1763807, which is invalid:

  • expected the bug to target the "4.4.0" release, but it targets "4.3.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1763807: Restore UPSTREAM from #24159: Expose a simple journald shim on the kubelet logs endpoint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@sttts: An error was encountered searching for bug 1776351 on the Bugzilla server at https://bugzilla.redhat.com:

Get https://bugzilla.redhat.com/rest/bug/1776351?api_key=CENSORED: dial tcp: i/o timeout
Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

Bug 1776351: Restore UPSTREAM from #24159: Expose a simple journald shim on the kubelet logs endpoint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sttts sttts changed the title Bug 1763807: Restore UPSTREAM from #24159: Expose a simple journald shim on the kubelet logs endpoint Bug 1776351: Restore UPSTREAM from #24159: Expose a simple journald shim on the kubelet logs endpoint Nov 25, 2019
@sttts
Copy link
Contributor Author

sttts commented Nov 25, 2019

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Nov 25, 2019
@openshift-ci-robot
Copy link

@sttts: This pull request references Bugzilla bug 1776351, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1776351: Restore UPSTREAM from #24159: Expose a simple journald shim on the kubelet logs endpoint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Nov 25, 2019
@openshift-ci-robot
Copy link

@sttts: This pull request references Bugzilla bug 1776351, which is valid.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 369a26a into openshift:master Nov 26, 2019
@openshift-ci-robot
Copy link

@sttts: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-gcp b2ec8ed link /test e2e-gcp
ci/prow/e2e-gcp-upgrade b2ec8ed link /test e2e-gcp-upgrade

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sttts
Copy link
Contributor Author

sttts commented Nov 26, 2019

/cherrypick release-4.3

@openshift-cherrypick-robot

@sttts: new pull request created: #24213

In response to this:

/cherrypick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants