Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extended util oauthserver - increase pod ready wait time #24217

Merged
merged 1 commit into from Nov 28, 2019
Merged

extended util oauthserver - increase pod ready wait time #24217

merged 1 commit into from Nov 28, 2019

Conversation

stlaz
Copy link
Member

@stlaz stlaz commented Nov 26, 2019

It seems that the images are being pulled for up to 55 seconds in
the CI test runs, which would leave the oauth-server to start for
only about 5 seconds.

Increase the timeout for pod readiness in order to stop jobs from
failing too often.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 26, 2019
@stlaz
extended util oauthserver - increase pod ready wait time
2fc999e 
It seems that the images are being pulled for up to 55 seconds in
the CI test runs, which would leave the oauth-server to start for
only about 5 seconds.

Increase the timeout for pod readiness in order to stop jobs from
failing too often.
@stlaz stlaz changed the title extended util oauthserver - increase pod ready wait time Bug 1765733: extended util oauthserver - increase pod ready wait time Nov 26, 2019
@openshift-ci-robot
Copy link

@stlaz: This pull request references Bugzilla bug 1765733, which is invalid:

  • expected the bug to target the "4.4.0" release, but it targets "4.3.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1765733: extended util oauthserver - increase pod ready wait time

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Nov 26, 2019
@stlaz stlaz changed the title Bug 1765733: extended util oauthserver - increase pod ready wait time extended util oauthserver - increase pod ready wait time Nov 26, 2019
@openshift-ci-robot
Copy link

@stlaz: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

extended util oauthserver - increase pod ready wait time

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Nov 26, 2019
@stlaz
Copy link
Member Author

stlaz commented Nov 26, 2019

let's just merge this and use the BZ for a backport

@mfojtik
Copy link
Member

mfojtik commented Nov 26, 2019

/retest

1 similar comment
@stlaz
Copy link
Member Author

stlaz commented Nov 26, 2019

/retest

@stlaz
Copy link
Member Author

stlaz commented Nov 28, 2019

/cherry-pick release-4.3

@openshift-cherrypick-robot
Copy link

@stlaz: once the present PR merges, I will cherry-pick it on top of release-4.3 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@p0lyn0mial
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2019
@mfojtik
Copy link
Member

mfojtik commented Nov 28, 2019

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JAORMX, mfojtik, p0lyn0mial, stlaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2019
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 5355a63 into openshift:master Nov 28, 2019
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 28, 2019
Merged
@openshift-cherrypick-robot
Copy link

@stlaz: new pull request created: #24239

In response to this:

/cherry-pick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stlaz
Copy link
Member Author

stlaz commented Mar 23, 2020

/cherry-pick release-4.2

@openshift-cherrypick-robot
Copy link

@stlaz: #24217 failed to apply on top of branch "release-4.2":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	test/extended/util/oauthserver/oauthserver.go
Falling back to patching base and 3-way merge...
Auto-merging test/extended/util/oauthserver/oauthserver.go
CONFLICT (content): Merge conflict in test/extended/util/oauthserver/oauthserver.go
Patch failed at 0001 extended util oauthserver - increase pod ready wait time

In response to this:

/cherry-pick release-4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JAORMX JAORMX JAORMX approved these changes

@deads2k deads2k Awaiting requested review from deads2k

@mfojtik mfojtik Awaiting requested review from mfojtik

Assignees

@p0lyn0mial p0lyn0mial

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@stlaz @openshift-ci-robot @mfojtik @openshift-cherrypick-robot @p0lyn0mial @openshift-bot @JAORMX @openshift-merge-robot