Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace hyperkube binary with a bash script #24275

Merged
merged 2 commits into from Dec 12, 2019
Merged

replace hyperkube binary with a bash script #24275

merged 2 commits into from Dec 12, 2019

Conversation

p0lyn0mial
Copy link
Contributor

@p0lyn0mial p0lyn0mial commented Dec 9, 2019 •
edited

since hyperkube has been removed from k/k (1.17) repository this pulls replaces it with a custom script that has similar behavior.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 9, 2019
@p0lyn0mial p0lyn0mial changed the title [WIP]no hyperkube [WIP] no hyperkube Dec 9, 2019
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 9, 2019
@p0lyn0mial
Copy link
Contributor Author

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 9, 2019
@p0lyn0mial p0lyn0mial force-pushed the rm-hyperkube branch 3 times, most recently from 9c120ae to 4bbeecc Compare December 9, 2019 22:16
@p0lyn0mial
Copy link
Contributor Author

requires openshift/release#6312

@p0lyn0mial
Copy link
Contributor Author

/retest

sttts
sttts reviewed Dec 10, 2019
View reviewed changes
hack/build-go.sh Outdated
vendor/k8s.io/kubernetes/cmd/kube-controller-manager
vendor/k8s.io/kubernetes/cmd/kube-proxy
vendor/k8s.io/kubernetes/cmd/kube-scheduler
vendor/k8s.io/kubernetes/cmd/kubectl
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is kubectl used anywhere?

@p0lyn0mial
Copy link
Contributor Author

/retest

3 similar comments
@p0lyn0mial
Copy link
Contributor Author

/retest

@p0lyn0mial
Copy link
Contributor Author

/retest

@p0lyn0mial
Copy link
Contributor Author

/retest

p0lyn0mial
p0lyn0mial commented Dec 11, 2019
View reviewed changes
hack/build-go.sh Outdated
fi
build_targets=(vendor/k8s.io/kubernetes/cmd/kube-apiserver
vendor/k8s.io/kubernetes/cmd/kube-controller-manager
vendor/k8s.io/kubernetes/cmd/kube-proxy
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be removed as well.

@p0lyn0mial p0lyn0mial changed the title [WIP] no hyperkube replace hyperkube binary with a bash script Dec 11, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 11, 2019
@deads2k
Copy link
Contributor

deads2k commented Dec 11, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, p0lyn0mial

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 11, 2019
@p0lyn0mial
Copy link
Contributor Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 11, 2019
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@p0lyn0mial
Copy link
Contributor Author

GCP is broken Error setting IAM policy for project

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@p0lyn0mial
Copy link
Contributor Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 7071a54 into openshift:master Dec 12, 2019
@p0lyn0mial p0lyn0mial mentioned this pull request Jun 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sttts sttts sttts left review comments

@bparees bparees Awaiting requested review from bparees

@jhadvig jhadvig Awaiting requested review from jhadvig

Assignees

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@p0lyn0mial @deads2k @openshift-ci-robot @openshift-bot @sttts @openshift-merge-robot