Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1784334: Revert "check ServiceCatalog basic usages for OCP 4.x" #24323

Merged
merged 2 commits into from Dec 18, 2019
Merged

Bug 1784334: Revert "check ServiceCatalog basic usages for OCP 4.x" #24323

merged 2 commits into from Dec 18, 2019

Conversation

jmrodri
Copy link
Contributor

@jmrodri jmrodri commented Dec 18, 2019

Supersedes PR #24315

@jmrodri
Revert "use apps/v1 instead of extensions/v1beta1 for deployment"
60c9824 
This reverts commit 8fa7be8.

This change was made to service catalog files which are being reverted.
@jmrodri
Bug 1784334: Revert "check ServiceCatalog basic usages for OCP 4.2"
9d18a47 
This reverts commit 446aa1f.

this test is causing consistent CI failures, we need to remove and
revisit the tests.
@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Dec 18, 2019
@openshift-ci-robot
Copy link

@jmrodri: This pull request references Bugzilla bug 1784334, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1784334: Revert "check ServiceCatalog basic usages for OCP 4.x"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Dec 18, 2019
@jmrodri jmrodri mentioned this pull request Dec 18, 2019
Closed
@mfojtik
Copy link
Member

mfojtik commented Dec 18, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmrodri, mfojtik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2019
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@wking wking mentioned this pull request Dec 18, 2019
Merged
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@mfojtik
Copy link
Member

mfojtik commented Dec 18, 2019

/override ci/prow/e2e-cmd

@openshift-ci-robot
Copy link

@mfojtik: Overrode contexts on behalf of mfojtik: ci/prow/e2e-cmd

In response to this:

/override ci/prow/e2e-cmd

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mfojtik
Copy link
Member

mfojtik commented Dec 18, 2019

No idea why is this not merged and still pending... this is flaking heavily and blocking other PR's.
It is simple revert so button merge should be safe.

@mfojtik mfojtik merged commit 70e98bf into openshift:master Dec 18, 2019
@openshift-ci-robot
Copy link

@jmrodri: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-gcp 9d18a47 link /test e2e-gcp

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jianzhangbjz jianzhangbjz mentioned this pull request Jan 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ironcladlou ironcladlou Awaiting requested review from ironcladlou

@knobunc knobunc Awaiting requested review from knobunc

Assignees

@mfojtik mfojtik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jmrodri @openshift-ci-robot @mfojtik @openshift-bot