Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1782467: move more image-eco db template tests from upstream repos to sample o… #24391

Merged
merged 1 commit into from Jan 16, 2020
Merged

Bug 1782467: move more image-eco db template tests from upstream repos to sample o… #24391

merged 1 commit into from Jan 16, 2020

Conversation

gabemontero
Copy link
Contributor

…perator installed

/assign @bparees
/assign @adambkaplan

@bparees
Copy link
Contributor

bparees commented Jan 13, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 13, 2020
@gabemontero
Copy link
Contributor Author

/refresh

@gabemontero
Copy link
Contributor Author

/retest

@gabemontero
Copy link
Contributor Author

/test e2e-aws-image-ecosystem

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

19 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@gabemontero
Copy link
Contributor Author

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 14, 2020
@gabemontero
Copy link
Contributor Author 

Cmd: "oc --namespace=e2e-test-mariadb-create-txmwv --config=/tmp/configfile103497059 process mariadb-ephemeral -n openshift",
        StdErr: "error: unable to process template\n  processedtemplates.template.openshift.io is forbidden: User \"e2e-test-mariadb-create-txmwv-user\" cannot create resource \"processedtemplates\" in API group \"template.openshift.io\" in the namespace \"openshift\"",

and

Cmd: "oc --namespace=e2e-test-mysql-create-qnpsw --config=/tmp/configfile840281241 process mysql-ephemeral -n openshift",
        StdErr: "error: unable to process template\n  processedtemplates.template.openshift.io is forbidden: User \"e2e-test-mysql-create-qnpsw-user\" cannot create resource \"processedtemplates\" in API group \"template.openshift.io\" in the namespace \"openshift\"",

@gabemontero
Copy link
Contributor Author

ok the permission failure on the scl enable tests were flakes

we have green image-ecosystem tests @bparees @adambkaplan ... if one of you could lgtm, with retests to move past the infra/unrelated component flakes in the other tests, we can get this merged

@gabemontero
Copy link
Contributor Author

/retest

@gabemontero
Copy link
Contributor Author

updated @bparees

@bparees
Copy link
Contributor

bparees commented Jan 15, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gabemontero
Copy link
Contributor Author

/test e2e-cmd

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@gabemontero
Copy link
Contributor Author

ok image-eco is green ... just circumnavigating non-related flakes now

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 575d106 into openshift:master Jan 16, 2020
@openshift-ci-robot
Copy link

@gabemontero: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-fips db9e7cf link /test e2e-aws-fips

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gabemontero gabemontero deleted the more-scl-eol-hoopla branch January 16, 2020 00:39
@gabemontero
Copy link
Contributor Author

/cherrypick release-4.3

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 16, 2020
Merged
@openshift-cherrypick-robot
Copy link

@gabemontero: new pull request created: #24407

In response to this:

/cherrypick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gabemontero
Copy link
Contributor Author

/cherrypick release-4.2

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 6, 2020
Merged
@openshift-cherrypick-robot
Copy link

@gabemontero: new pull request created: #24511

In response to this:

/cherrypick release-4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gabemontero gabemontero mentioned this pull request Feb 6, 2020
Merged
@gabemontero gabemontero mentioned this pull request Feb 14, 2020
Merged
@gabemontero
Copy link
Contributor Author

/cherrypick release-3.11

@openshift-cherrypick-robot
Copy link

@gabemontero: #24391 failed to apply on top of branch "release-3.11":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	test/extended/image_ecosystem/mariadb_ephemeral.go
M	test/extended/image_ecosystem/mongodb_ephemeral.go
M	test/extended/image_ecosystem/mysql_ephemeral.go
M	test/extended/testdata/bindata.go
Falling back to patching base and 3-way merge...
Auto-merging test/extended/testdata/bindata.go
CONFLICT (content): Merge conflict in test/extended/testdata/bindata.go
Auto-merging test/extended/image_ecosystem/mysql_ephemeral.go
Auto-merging test/extended/image_ecosystem/mongodb_ephemeral.go
Auto-merging test/extended/image_ecosystem/mariadb_ephemeral.go
Patch failed at 0001 move more image-eco db template tests from upstream repos to sample operator installed

In response to this:

/cherrypick release-3.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bparees bparees bparees left review comments

Assignees

@bparees bparees

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@gabemontero @bparees @openshift-bot @openshift-ci-robot @openshift-cherrypick-robot @openshift-merge-robot