Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1790825: fix test flake in olm tests #24436

Merged
merged 1 commit into from Mar 19, 2020

Conversation

ecordell
Copy link
Contributor

If the operatrgroup is not ready by the time the CSV is created, the CSV
may temporarily make the CSV go unhealthy. This emits an alert, which
can make the prometheus test ensuring no alerts fail.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 21, 2020
@openshift-ci-robot
Copy link

@ecordell: This pull request references Bugzilla bug 1790825, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1790825: fix test flake in olm tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 21, 2020
@ecordell
Copy link
Contributor Author

/retest

1 similar comment
@ecordell
Copy link
Contributor Author

/retest

@kevinrizza
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2020
@Bowenislandsong
Copy link

/retest

3 similar comments
@ecordell
Copy link
Contributor Author

/retest

@ecordell
Copy link
Contributor Author

/retest

@ecordell
Copy link
Contributor Author

/retest

@ecordell ecordell closed this Jan 28, 2020
@ecordell ecordell reopened this Jan 28, 2020
@openshift-ci-robot
Copy link

@ecordell: This pull request references Bugzilla bug 1790825, which is valid.

In response to this:

Bug 1790825: fix test flake in olm tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ecordell
Copy link
Contributor Author

/retest

1 similar comment
@ecordell
Copy link
Contributor Author

/retest

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2020
@ecordell
Copy link
Contributor Author

/retest

@ecordell
Copy link
Contributor Author

ecordell commented Feb 1, 2020

/retest

@ecordell
Copy link
Contributor Author

ecordell commented Feb 4, 2020

/retest

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 11, 2020
@ecordell ecordell force-pushed the fix-olm-test-flake branch 3 times, most recently from a3f3859 to b4517ce Compare March 17, 2020 20:48
@wking
Copy link
Member

wking commented Mar 17, 2020

This is killing us in 4.5 CI, causing ~34% of the past day's 4.5 promotion failures. Can we get a review, @bparees?

@bparees
Copy link
Contributor

bparees commented Mar 18, 2020

i've put a comment on it, but more importantly i'd expect the olm team to be driving this through merge, or for it to be esclated to their group lead @shawn-hurley. unfortunately the github review assignees don't mean anything useful in terms of who is best qualified to review/merge changes.

@ecordell
Copy link
Contributor Author

I'm actively working on it as of this afternoon - other changes merged which required changes to this PR. Looks like I missed something.

@ecordell
Copy link
Contributor Author

/retest

@ecordell
Copy link
Contributor Author

/retest

I see networking and etcd issues in gcp and fips

@ecordell
Copy link
Contributor Author

/retest

if the operatrgroup is not ready by the time the CSV is created, the CSV
may temporarily make the CSV go unhealthy. This emits an alert, which
can make the prometheus test ensuring no alerts fail.
@shawn-hurley
Copy link

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 18, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ecordell, kevinrizza, shawn-hurley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2020
@ecordell
Copy link
Contributor Author

/test e2e-aws-fips

@ecordell
Copy link
Contributor Author

/retest

this test is no longer causing problems. looks like there are other, unrelated flakes.

@ecordell
Copy link
Contributor Author

/retest

1 similar comment
@ecordell
Copy link
Contributor Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 2451ce2 into openshift:master Mar 19, 2020
@openshift-ci-robot
Copy link

@ecordell: All pull requests linked via external trackers have merged. Bugzilla bug 1790825 has been moved to the MODIFIED state.

In response to this:

Bug 1790825: fix test flake in olm tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants