Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPSTREAM: 85898: Fix multinode storage e2e tests for multizone clusters #24437

Merged

Conversation

tsmetana
Copy link
Member

The multi-node PV test creates a PV, starts a pod that writes data to a file on
the PV, then kills the pod and starts another with node anti-affinity to read
the data from the PV attached to a different node. This is problematic on
multi-AZ clusters: there may only be one node in a zone and for volumes that
can't be transferred among zones (AWS EBS, GCE PD, ...) the test would fail.

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 22, 2020
@openshift-ci-robot openshift-ci-robot added the vendor-update Touching vendor dir or related files label Jan 22, 2020
@bertinatto
Copy link
Member

/retest

@bertinatto
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2020
@bertinatto
Copy link
Member

/assign @soltysh
for approval (also approved the upstream patch)

@bertinatto
Copy link
Member

/retest

2 similar comments
@bertinatto
Copy link
Member

/retest

@bertinatto
Copy link
Member

/retest

@knobunc
Copy link
Contributor

knobunc commented Jan 22, 2020

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2020
@bertinatto
Copy link
Member

/retest

4 similar comments
@bertinatto
Copy link
Member

/retest

@bertinatto
Copy link
Member

/retest

@bertinatto
Copy link
Member

/retest

@bertinatto
Copy link
Member

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@bertinatto
Copy link
Member

/test e2e-cmd

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@bertinatto
Copy link
Member

/test e2e-cmd

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@bertinatto
Copy link
Member

/retest

The multi-node PV test creates a PV, starts a pod that writes data to a file on
the PV, then kills the pod and starts another with node anti-affinity to read
the data from the PV attached to a different node. This is problematic on
multi-AZ clusters: there may only be one node in a zone and for volumes that
can't be transferred among zones (AWS EBS, GCE PD, ...) the test would fail.
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2020
@bertinatto
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, knobunc, tsmetana

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bertinatto
Copy link
Member

/retest

3 similar comments
@bertinatto
Copy link
Member

/retest

@bertinatto
Copy link
Member

/retest

@bertinatto
Copy link
Member

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@bertinatto
Copy link
Member

/retest

1 similar comment
@bertinatto
Copy link
Member

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@bertinatto
Copy link
Member

/retest

1 similar comment
@bertinatto
Copy link
Member

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@bertinatto
Copy link
Member

/retest

@openshift-merge-robot openshift-merge-robot merged commit 15d7357 into openshift:master Jan 29, 2020
@tsmetana tsmetana deleted the fix-multinode-tests branch October 9, 2020 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants