allow build git/proxy e2e error msg parsing to work with multiple git… #24520
Conversation
|
@gabemontero: This pull request references Bugzilla bug 1750650, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/invalid-bug
gabemontero
changed the title
|
Assuming we agree to merge this in the short term, I'll open a 4.4 bug for this. |
openshift-ci-robot
removed
the
bugzilla/invalid-bug
|
@gabemontero: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
approved
|
/retest |
1 similar comment
|
/retest |
|
fyi e2e-gcp-builds passed and that is the one affected by this e2e only PRs changes |
|
OK @adambkaplan we have green tests open a bug and get into 4.4, or wait until 4.5 ? |
openshift-ci-robot
added
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan, gabemontero The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Agree on the risk @adambkaplan Just to be clear, this PR is just the e2e tweaks to accommodate old and new The actual change is going to be a combination of library-go and builder changes. Those changes will need this tweak to merge. |
|
@adambkaplan with 4.5 now open are you good with unholding this PR Reminder: this only enables support for parsing git messages in our e2e's for both the current older version's message, as well as the new SCL version IF we choose to pull that in to address the current HTTPS proxy limitation with git (via its dependencies) thanks @ricardomaraschini FYI ^^ |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
terraform flake on serial failure /test e2e-aws-serial |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
quick update - none of the e2e churn has been with the git test cases tweaked by this PR, and those tests did pass a while back with https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/24520/pull-ci-openshift-origin-master-e2e-gcp-builds/1075/ |
|
Keeping an eye on e2e-gcp-builds to see if new unrelated flakes are with us. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/hold I think we may have something in 4.5 changing such that our build cluster configuration tests are failing @adambkaplan https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/24520/pull-ci-openshift-origin-master-e2e-gcp-builds/1206 is the latest incarnation Have you seen/heard anything? I'll try to triage the above run in a bit ... gonna wait to see how the current run does. But we've had a couple of similar failures in a row now. |
openshift-ci-robot
added
the
do-not-merge/hold
|
@gabemontero I think those disruptive tests are broken by a fix I made in 4.5. #24582 should hopefully fix this |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
5 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
… versions
Based on prototyping in openshift/builder#99 for using the https proxy friendly versions of scl git on rhel7, some slight adjustments to the existing build proxy related e2e error message parsing is needed to account for both the base version of
giton rhel7 and the scl version,as the error messages changed ever slow slightly.
Don't see non-message parsing alternatives to those tests. But of course suggestions welcome.
Of course merging this change does not mean we are committing to fully doing git https proxy support, but this should be a benign change that facilitates our testing when that work is officially taken on.
@openshift/openshift-team-developer-experience FYI
/assign @adambkaplan