Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1811020: Fix count of failures in JUnit output #24645

Merged
merged 1 commit into from Mar 8, 2020
Merged

Bug 1811020: Fix count of failures in JUnit output #24645

merged 1 commit into from Mar 8, 2020

Conversation

jsafrane
Copy link
Contributor

@jsafrane jsafrane commented Mar 6, 2020 •
edited

Don't count success as a failure. Looks like copy-paste "typo".

@jsafrane
Fix count of failures in JUnit output
2df904b 
Don't count success as a failure.
@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Mar 6, 2020
@openshift-ci-robot
Copy link

@jsafrane: This pull request references Bugzilla bug 1811020, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1811020: Fix count of failures in JUnit output

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 6, 2020
@jsafrane
Copy link
Contributor Author

jsafrane commented Mar 6, 2020

/test pull-ci-openshift-origin-master-e2e-aws-csi

@jsafrane
Copy link
Contributor Author

jsafrane commented Mar 6, 2020

/test e2e-aws-csi

@openshift-ci-robot
Copy link

@jsafrane: This pull request references Bugzilla bug 1811020, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1811020: Fix count of failures in JUnit output

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jsafrane
Copy link
Contributor Author

jsafrane commented Mar 6, 2020

/retest

@jsafrane
Copy link
Contributor Author

jsafrane commented Mar 6, 2020

From pull-ci-openshift-origin-master-e2e-aws-fips from this PR:

JUnit says <testsuite name="openshift-tests" tests="2291" skipped="1337" failures="1" time="1709">, which is correct.

knobunc
knobunc approved these changes Mar 6, 2020
View reviewed changes
Copy link
Contributor

@knobunc knobunc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2020
@knobunc
Copy link
Contributor

knobunc commented Mar 6, 2020

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, knobunc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2020
@huffmanca
Copy link
Contributor

/test e2e-cmd

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@jsafrane
Copy link
Contributor Author

jsafrane commented Mar 7, 2020

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

9 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit b11514b into openshift:master Mar 8, 2020
@openshift-ci-robot
Copy link

@jsafrane: All pull requests linked via external trackers have merged. Bugzilla bug 1811020 has been moved to the MODIFIED state.

In response to this:

Bug 1811020: Fix count of failures in JUnit output

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knobunc knobunc knobunc approved these changes

@csrwng csrwng Awaiting requested review from csrwng

@spadgett spadgett Awaiting requested review from spadgett

Assignees

@knobunc knobunc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jsafrane @openshift-ci-robot @knobunc @huffmanca @openshift-bot @openshift-merge-robot