Bug 1749468: UPSTREAM: 88734: Work-around for missing metrics on CRI-O exited containers #24653
Conversation
openshift-ci-robot
added
the
size/M
…ainers HPA needs metrics for exited init containers before it will take action. By setting memory and CPU usage to zero for any containers that cAdvisor didn't provide statistics for, we are assured that HPA will be able to correctly calculate pod resource usage.
|
FYI, upstream PR kubernetes/kubernetes#88734 has approval and lgtm, but can't merge because it's not tagged for the v1.18 milestone. This is to address the bug https://bugzilla.redhat.com/show_bug.cgi?id=1749468 |
|
/lgtm holding for the upstream merge |
openshift-ci-robot
added
do-not-merge/hold
|
/assign @sjenning |
|
PR is lgtm/approve upstream, just waiting for merge |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joelsmith, rphillips, sjenning The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
Upstream just merged. |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
5 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/cherrypick release-4.4 |
|
@joelsmith: new pull request created: #24671 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retitle Bug 1749468: UPSTREAM: 88734: Work-around for missing metrics on CRI-O exited containers |
openshift-ci-robot
changed the title
|
@joelsmith: All pull requests linked via external trackers have merged. Bugzilla bug 1749468 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick release-4.3 |
|
@joelsmith: new pull request created: #24860 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
HPA needs metrics for exited init containers before it will
take action. By setting memory and CPU usage to zero for any
containers that cAdvisor didn't provide statistics for, we
are assured that HPA will be able to correctly calculate
pod resource usage.