Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/extended/cli/mustgather: Separate gather_audit_logs test #24680

Closed
wants to merge 1 commit into from

Commits on May 29, 2020

  1. test/extended/cli/mustgather: Separate gather_audit_logs test

    [1] is removing these from the default gather, because they're mostly
    useful for internal debugging, less useful in end-user bug reports,
    and can run to hundreds of megabytes.  But we still want to ensure
    that they work as expected when they are explicitly requested.  This
    commit pulls the audit-log checks out of the test-case for the generic
    invocation.  And it adds a new test case with those checks after an
    explict gather_audit_logs request.
    
    The EOF sleep was recommended by Maciej [2,3], although it's not clear
    to me how the oc call could exit success before the output directory
    was on disk.
    
    The annotation change was generated with:
    
      $ hack/verify-generated-bindata.sh
    
    [1]: openshift/must-gather#143
    [2]: openshift#24680 (comment)
    [3]: openshift#24680 (comment)
    wking committed May 29, 2020
    Copy the full SHA
    6dcbbff View commit details
    Browse the repository at this point in the history