New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UPSTREAM: 89055: Remove wait.Until for running Kubelet Bootstrap #24686
Conversation
holding for upstream merge /lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rphillips, sjenning, tedyu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test e2e-gcp |
/hold cancel |
/test e2e-gcp-upgrade |
1 similar comment
/test e2e-gcp-upgrade |
/retest Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/hold cancel |
/test e2e-gcp-upgrade |
/retest Please review the full test history for this PR and help us cut down flakes. |
As @liggitt outlined in #88779 (comment) , there are two options in preventing multiple parallel Run goroutines.
This PR adopts option #1.