Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1790825: fix test flake in operators test #24723

Merged
merged 1 commit into from Mar 19, 2020
Merged

Bug 1790825: fix test flake in operators test #24723

merged 1 commit into from Mar 19, 2020

Conversation

ecordell
Copy link
Contributor

When the namespace is deleted, the operatorgroup can be removed
before the csv, which can cause the csv to flip to failed.

there is an alert that fires when the csv flips to failed, which
can cause the monitoring test ensuring no alerts fired to fail

@ecordell
fix test flake in operators test
0158324 
when the namespace is deleted, the operatorgroup can be removed
before the csv, which can cause the csv to flip to failed.

there is an alert that fires when the csv flips to failed, which
can cause the monitoring test ensuring no alerts fired to fail
@openshift-ci-robot
Copy link

@ecordell: This pull request references Bugzilla bug 1790825, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1790825: fix test flake in operators test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Mar 19, 2020
@ecordell
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 19, 2020
@openshift-ci-robot
Copy link

@ecordell: This pull request references Bugzilla bug 1790825, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bparees
Copy link
Contributor

bparees commented Mar 19, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 19, 2020
@bparees
Copy link
Contributor

bparees commented Mar 19, 2020

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, ecordell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 19, 2020
@ecordell
Copy link
Contributor Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@ecordell
Copy link
Contributor Author

/refresh

@ecordell
Copy link
Contributor Author

/retest

status seems wonky - I think g2p-upgrade is the only real failure.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@ecordell
Copy link
Contributor Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit 0197305 into openshift:master Mar 19, 2020
@openshift-ci-robot
Copy link

@ecordell: All pull requests linked via external trackers have merged. Bugzilla bug 1790825 has been moved to the MODIFIED state.

In response to this:

Bug 1790825: fix test flake in operators test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ecordell ecordell mentioned this pull request Mar 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bparees bparees Awaiting requested review from bparees

@knobunc knobunc Awaiting requested review from knobunc

Assignees

@bparees bparees

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ecordell @openshift-ci-robot @bparees @openshift-bot @openshift-merge-robot