Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1809861: add extract image init container failure test #24731

Merged
merged 2 commits into from Mar 22, 2020
Merged

Bug 1809861: add extract image init container failure test #24731

merged 2 commits into from Mar 22, 2020

Conversation

gabemontero
Copy link
Contributor

/hold

until openshift/builder#142 merges new test should fail
we will initially want to make sure the new test fails before openshift/builder#142 merges

@openshift/openshift-team-developer-experience

/assign @bparees

note as the code path in openshift/builder is exactly the same for docker and s2i strategies, I chose to not add tests for both

also, an easily producible ManageDockerfile failure did not come to mind

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 20, 2020
@openshift-ci-robot
Copy link

@gabemontero: This pull request references Bugzilla bug 1809861, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1809861: add extract image init container failure test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Mar 20, 2020
@openshift-ci-robot openshift-ci-robot added the vendor-update Touching vendor dir or related files label Mar 20, 2020
@gabemontero gabemontero force-pushed the new-bld-init-cont-reasons-msgs branch from 0152d23 to c6e7663 Compare March 20, 2020 15:45
bparees
bparees reviewed Mar 20, 2020
View reviewed changes
Copy link
Contributor

@bparees bparees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like a lot of copy/paste/mutate errors in here.

test/extended/builds/failure_status.go Outdated Show resolved Hide resolved
test/extended/builds/failure_status.go Outdated Show resolved Hide resolved
test/extended/builds/failure_status.go Outdated Show resolved Hide resolved
test/extended/builds/failure_status.go Outdated Show resolved Hide resolved
test/extended/testdata/builds/statusfail-fetchimagecontentdocker.yaml Outdated Show resolved Hide resolved
@gabemontero
Copy link
Contributor Author

looks like a lot of copy/paste/mutate errors in here.

sigh ... yes there are ... thanks for the commit suggestions, but I may just do it on my end

the yaml in particular I swore I changed ... maybe I got them confused with logsnippet changes

I think I've reached critical mass on how many bugs I can work concurrently ;-)

apologies for the churn

@gabemontero gabemontero force-pushed the new-bld-init-cont-reasons-msgs branch from c6e7663 to 9e33b22 Compare March 20, 2020 19:11
@gabemontero
Copy link
Contributor Author

ok the failure_status.go diff looks sane now @bparees

@gabemontero gabemontero mentioned this pull request Mar 20, 2020
Merged
@bparees
Copy link
Contributor

bparees commented Mar 20, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 20, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 20, 2020
@gabemontero
Copy link
Contributor Author

Our new test case failed as expected in e2e-gcp-builds:


[sig-builds][Feature:Builds][Slow]  update failure status  Build status Docker fetch image content failure  should contain the Docker build fetch image content reason and message  [Suite:openshift] expand_less | 22s
-- | --
fail [github.com/openshift/origin/test/extended/builds/failure_status.go:102]: Expected     <v1.StatusReason>: GenericBuildFailed to equal     <v1.StatusReason>: FetchImageContentFailed

@gabemontero
Copy link
Contributor Author

/test e2e-cmd

@gabemontero
Copy link
Contributor Author

/retest

@gabemontero
Copy link
Contributor Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 21, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit afa7ce3 into openshift:master Mar 22, 2020
@openshift-ci-robot
Copy link

@gabemontero: All pull requests linked via external trackers have merged. Bugzilla bug 1809861 has been moved to the MODIFIED state.

In response to this:

Bug 1809861: add extract image init container failure test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gabemontero gabemontero deleted the new-bld-init-cont-reasons-msgs branch March 22, 2020 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bparees bparees bparees left review comments

@coreydaley coreydaley Awaiting requested review from coreydaley

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@bparees bparees

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@gabemontero @openshift-ci-robot @bparees @openshift-bot @openshift-merge-robot