Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1817039: [4.4] UPSTREAM: 88506: Honor status.podIP over status.podIPs, node.spec.podCIDR over node.spec.podCIDRs #24762

Merged
merged 1 commit into from Mar 26, 2020
Merged

Bug 1817039: [4.4] UPSTREAM: 88506: Honor status.podIP over status.podIPs, node.spec.podCIDR over node.spec.podCIDRs #24762

merged 1 commit into from Mar 26, 2020

Conversation

danwinship
Copy link
Contributor

Backport of #24750, but via cherry-picking the upstream backport rather than the origin master PR

/assign @deads2k

@openshift-ci-robot
Copy link

@danwinship: This pull request references Bugzilla bug 1817039, which is invalid:

  • expected dependent Bugzilla bug 1816302 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1817039: [4.4] UPSTREAM: 88506: Honor status.podIP over status.podIPs, node.spec.podCIDR over node.spec.podCIDRs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Mar 25, 2020
@openshift-ci-robot openshift-ci-robot added the vendor-update Touching vendor dir or related files label Mar 25, 2020
@danwinship danwinship mentioned this pull request Mar 25, 2020
Closed
@sdodson
Copy link
Member

sdodson commented Mar 25, 2020

/retest

@deads2k
Copy link
Contributor

deads2k commented Mar 25, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@jwforres
Copy link
Member

Overriding BZ requirement since this bug manifests specifically in the 4.2 -> 4.3 upgrades

@jwforres jwforres added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 26, 2020
@jwforres
Copy link
Member

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@jwforres
Copy link
Member

/retest

@openshift-merge-robot openshift-merge-robot merged commit d7ae353 into openshift:release-4.4 Mar 26, 2020
@openshift-ci-robot
Copy link

@danwinship: All pull requests linked via external trackers have merged: . Bugzilla bug 1817039 has been moved to the MODIFIED state.

In response to this:

Bug 1817039: [4.4] UPSTREAM: 88506: Honor status.podIP over status.podIPs, node.spec.podCIDR over node.spec.podCIDRs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sdodson sdodson mentioned this pull request Mar 26, 2020
Merged
@danwinship danwinship deleted the pod-ip-pod-ips-4.4 branch March 30, 2020 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bparees bparees Awaiting requested review from bparees

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@danwinship @openshift-ci-robot @sdodson @deads2k @openshift-bot @jwforres @openshift-merge-robot