Metrics should be exposed over secure channel #24803
Conversation
openshift-ci-robot
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
the
approved
paulfantom
force-pushed
the
secure_metrics
branch
from
473cb34
to
fd2bbd2
Compare
paulfantom
force-pushed
the
secure_metrics
branch
from
fd2bbd2
to
264b1ca
Compare
paulfantom
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
| @@ -230,6 +230,44 @@ var _ = g.Describe("[sig-instrumentation] Prometheus", func() { | |||
| } | |||
| return true, nil | |||
| })).NotTo(o.HaveOccurred(), "possibly some services didn't register ServiceMonitors to allow metrics collection") | |||
|
|
|||
| g.By("verifying all targets are exposing metrics over secure channel") | |||
There was a problem hiding this comment.
Right above there is a line that says:
// TODO: should probably be https
Should that now be https with this PR, or do we just remove that at least for CVO, as it checks the targets page as well
verifying all expected jobs have a working target
There was a problem hiding this comment.
They should be https and some of them already are, but not all (crio, cvo) expose metrics over https as of now. So that "TODO" is still valid.
There was a problem hiding this comment.
Also that test should stay as it checks for some crucial targets to be up.
| o.Expect(err).NotTo(o.HaveOccurred()) | ||
|
|
||
| // Currently following targets do not secure their /metrics endpoints: | ||
| // job="cco-metrics" - https://bugzilla.redhat.com/show_bug.cgi?id=1809194 |
There was a problem hiding this comment.
Should we leave a note in the bugzillas to remove themselves from this list after they merge their PRs?
There was a problem hiding this comment.
Yes, I plan on doing that after this is merged.
|
/retest |
|
/test verify |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lilic, paulfantom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
as in title