Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1814054: UPSTREAM: 89885: allow to read openstack cloud provider config from a secret #24834

Merged
merged 1 commit into from Apr 6, 2020
Merged

Bug 1814054: UPSTREAM: 89885: allow to read openstack cloud provider config from a secret #24834

merged 1 commit into from Apr 6, 2020

Conversation

Fedosin
Copy link
Contributor

@Fedosin Fedosin commented Apr 5, 2020

This patch brings back the downstream changes that were introduced to allow reading openstack cloud provider config from a secret.
They are available in release-4.4, but were reverted in master with #24719

This change includes:

  • Ability to read metadata values for kubelet. Since the service does not have access to the secret to read the configuration, but it needs data to download (e.g. hostname or flavor), we are trying to get it from the metadata server.
  • Deprecation of kubeConfig parameter. Now we read the file that was provided with --kubeconfig option.

@openshift-ci-robot openshift-ci-robot added the vendor-update Touching vendor dir or related files label Apr 5, 2020
@Fedosin
Copy link
Contributor Author

Fedosin commented Apr 5, 2020

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 5, 2020
@Fedosin
Copy link
Contributor Author

Fedosin commented Apr 5, 2020

/test e2e-openstack

@sttts
Copy link
Contributor

sttts commented Apr 6, 2020

/retest

@Fedosin Fedosin changed the title UPSTREAM: <carry>: allow to read openstack cloud provider config from a secret UPSTREAM: 89885: allow to read openstack cloud provider config from a secret Apr 6, 2020
… secret

This patch brings back the downstream changes that were introduced
to allow reading openstack cloud provider config from a secret.
They are available in release-4.4, but were reverted in master with
#24719

This change includes:

- Ability to read metadata values for kubelet. Since the service
does not have access to the secret to read the configuration, but
it needs data to download (e.g. hostname or flavor), we are trying
to get it from the metadata server.

- Deprecation of kubeConfig parameter. Now we read the file that
was provided with --kubeconfig option.
@Fedosin Fedosin changed the title UPSTREAM: 89885: allow to read openstack cloud provider config from a secret Bug 1814054: UPSTREAM: 89885: allow to read openstack cloud provider config from a secret Apr 6, 2020
@openshift-ci-robot
Copy link

@Fedosin: This pull request references Bugzilla bug 1814054, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1814054: UPSTREAM: 89885: allow to read openstack cloud provider config from a secret

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Apr 6, 2020
@Fedosin
Copy link
Contributor Author

Fedosin commented Apr 6, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 6, 2020
@sttts
Copy link
Contributor

sttts commented Apr 6, 2020

/lgtm
/approve
/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 6, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Fedosin, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 6, 2020
@Fedosin
Copy link
Contributor Author

Fedosin commented Apr 6, 2020

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 6, 2020
@Fedosin
Copy link
Contributor Author

Fedosin commented Apr 6, 2020

/retest

@Fedosin
Copy link
Contributor Author

Fedosin commented Apr 6, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 6, 2020
@openshift-merge-robot openshift-merge-robot merged commit 9b0f0fb into openshift:master Apr 6, 2020
@openshift-ci-robot
Copy link

@Fedosin: All pull requests linked via external trackers have merged: openshift/origin#24834. Bugzilla bug 1814054 has been moved to the MODIFIED state.

In response to this:

Bug 1814054: UPSTREAM: 89885: allow to read openstack cloud provider config from a secret

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants