Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1842631: openshift-tests: add run-resourcewatch command #24845

Merged
merged 3 commits into from Apr 11, 2020
Merged

Bug 1842631: openshift-tests: add run-resourcewatch command #24845

merged 3 commits into from Apr 11, 2020

Conversation

mfojtik
Copy link
Member

@mfojtik mfojtik commented Apr 7, 2020 •
edited

This command will start watching changes in *.config.openshift.io resources (including all cluster operators) and record all changes into local Git repository as a "commit".

Usage:

$ openshift-tests run-resourcewatch

If running inside the pod, it will use the SA token of the pod.

Additionally, it will produce Prometheus metrics that will contain timeline of changes in clusteroperator resource status:

# HELP openshift_ci_monitor_operator_cluster_operator_status [ALPHA] A metric that tracks individual cluster operator status.
# TYPE openshift_ci_monitor_operator_cluster_operator_status gauge
openshift_ci_monitor_operator_cluster_operator_status{condition="Available",name="authentication",status="True"} 1.586055762e+09
openshift_ci_monitor_operator_cluster_operator_status{condition="Available",name="cloud-credential",status="True"} 1.586054345e+09

Follow ups:

  • Wire this into jobs that run openshift-tests (e2e-aws, etc..)
  • Make sure we archive the Git repository and copy it into artifacts
  • Figure out if we can make service monitor and the aggregated prometheus to scrape the metrics from this operator.

More details: https://github.com/mfojtik/ci-monitor-operator

@mfojtik
Copy link
Member Author

mfojtik commented Apr 7, 2020

/assign @deads2k
/cc @damemi

@openshift-ci-robot openshift-ci-robot added vendor-update Touching vendor dir or related files approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 7, 2020
tnozicka
tnozicka reviewed Apr 7, 2020
View reviewed changes
glide.lock Outdated Show resolved Hide resolved
@deads2k
Copy link
Contributor

deads2k commented Apr 7, 2020

yeah, you changed vendored k8s by accident. don't mess with that.

@mfojtik
Copy link
Member Author

mfojtik commented Apr 7, 2020

@deads2k publishing bot was broken, i'm revendoring now.

@mfojtik
Copy link
Member Author

mfojtik commented Apr 8, 2020

/retest

@mfojtik
Copy link
Member Author

mfojtik commented Apr 8, 2020

@deads2k @damemi this is ready for review

damemi
damemi approved these changes Apr 8, 2020
View reviewed changes
Copy link

@damemi damemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

pkg/monitor/resourcewatch/controller/configmonitor/crd_controller.go
Comment on lines +82 to +86
if currentKinds.Has(gvk.Kind) {
continue
}
currentKinds.Insert(gvk.Kind)
currentConfigResources = append(currentConfigResources, gvk)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: you could just condense these into a if !currentKinds.Has(gvk.Kind) block and drop the continue

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damemi, mfojtik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mfojtik
Copy link
Member Author

mfojtik commented Apr 8, 2020

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@damemi damemi mentioned this pull request Apr 9, 2020
Closed
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

23 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit dbe978f into openshift:master Apr 11, 2020
@damemi damemi mentioned this pull request Apr 16, 2020
Closed
@damemi damemi mentioned this pull request May 28, 2020
Merged
@damemi
Copy link

damemi commented Jun 1, 2020

/retitle Bug 1842631: openshift-tests: add run-resourcewatch command

@openshift-ci-robot openshift-ci-robot changed the title openshift-tests: add run-resourcewatch command Bug 1842631: openshift-tests: add run-resourcewatch command Jun 1, 2020
@openshift-ci-robot
Copy link

@mfojtik: All pull requests linked via external trackers have merged: . Bugzilla bug 1842631 has been moved to the MODIFIED state.

In response to this:

Bug 1842631: openshift-tests: add run-resourcewatch command

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnozicka tnozicka tnozicka left review comments

@damemi damemi damemi approved these changes

@csrwng csrwng Awaiting requested review from csrwng

@pweil- pweil- Awaiting requested review from pweil-

Assignees

@damemi damemi

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@mfojtik @deads2k @openshift-ci-robot @openshift-bot @damemi @tnozicka @openshift-merge-robot