Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1834343: router: Re-enable h2spec and grpc-interop e2e tests #24976

Merged
merged 2 commits into from May 20, 2020
Merged

Bug 1834343: router: Re-enable h2spec and grpc-interop e2e tests #24976

merged 2 commits into from May 20, 2020

Conversation

frobware
Copy link
Contributor

@frobware frobware commented May 13, 2020 •
edited

This re-enables the h2spec and grpc-interop tests for the router. They were disabled by PR #24913. The way http/2 support is enabled was changed in openshift/router#125 and this PR reacts to those changes.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels May 13, 2020
@openshift-ci-robot
Copy link

@frobware: This pull request references Bugzilla bug 1834343, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1834343: router: Re-enable h2spec and grpc-interop e2e tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@frobware
Copy link
Contributor Author

/cc @Miciah @danehans

@frobware
Copy link
Contributor Author

/retest

@frobware
Copy link
Contributor Author

/assign @knobunc

@frobware
Copy link
Contributor Author

/retest

@frobware
Copy link
Contributor Author

/hold

I notice testing this elsewhere today that the grpc tests are failing. Not clear why they work in the PR.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 15, 2020
@frobware
Copy link
Contributor Author

/hold cancel

Latest commits adds a readiness probe to grpc-interop and h2spec pods.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 15, 2020
@openshift-ci-robot
Copy link

@frobware: This pull request references Bugzilla bug 1834343, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1834343: router: Re-enable h2spec and grpc-interop e2e tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@frobware
Copy link
Contributor Author

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 15, 2020
@frobware
Copy link
Contributor Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 18, 2020
@frobware
Copy link
Contributor Author

@Miciah the changes here are the bare minimum based on our discussion last week; certs added, readiness probes added. I think we should collapse h2spec to just re-encrypt as a separate PR.

@frobware
Copy link
Contributor Author

/assign @knobunc

@frobware
Copy link
Contributor Author

/retest

@frobware
test/extended/router: re-enable h2spec and grpc-interop tests
b605728 
These were disabled when fixing:

  https://bugzilla.redhat.com/show_bug.cgi?id=1825354

openshift/router#125 reworked http/2 support
to require a custom certificate for edge and reencrypt routes so this
change also adds a custom cert for those route types. Includes a
drive-by fix for the makefile in grpc-interop and additionally adds
readiness probes.
@frobware
test/extended/router: update bindata
824743f
@frobware
Copy link
Contributor Author 

Installing from release registry.svc.ci.openshift.org/ci-op-r6ct7yzq/release@sha256:b26f7ef255831df65df2736a35f8f890752db08c85a98060ea99fdffec21322b
level=info msg="Credentials loaded from environment variable \"GOOGLE_CLOUD_KEYFILE_JSON\", file \"/etc/openshift-installer/gce.json\""
level=info msg="Consuming Install Config from target directory"
level=warning msg="Found override for release image. Please be warned, this is not advised"
level=info msg="Credentials loaded from environment variable \"GOOGLE_CLOUD_KEYFILE_JSON\", file \"/etc/openshift-installer/gce.json\""
level=fatal msg="failed to fetch Terraform Variables: failed to generate asset \"Terraform Variables\": failed to get GCP public zone: failed to list DNS Zones: googleapi: Error 503: Backend Error, backendError"

/retest

@frobware
Copy link
Contributor Author 

Failing tests:

[sig-cli][Feature:LegacyCommandTests][Disruptive][Serial] test-cmd: test/cmd/projects.sh [Suite:openshift]

2020/05/20 15:36:07 Container test in pod e2e-cmd failed, exit code 1, reason Error
2020/05/20 15:46:45 Copied 147.90MB of artifacts from e2e-cmd to /logs/artifacts/e2e-cmd
2020/05/20 15:46:45 Releasing lease for "gcp-quota-slice"
2020/05/20 15:46:45 No custom metadata found and prow metadata already exists. Not updating the metadata.
2020/05/20 15:46:46 Ran for 1h41m36s
error: some steps failed:
  * could not run steps: step e2e-cmd failed: template pod "e2e-cmd" failed: the pod ci-op-qnsmrd7f/e2e-cmd failed after 1h12m15s (failed containers: test): ContainerFailed one or more containers exited

Container test exited with code 1, reason Error
---

/retest

@Miciah
Copy link
Contributor

Miciah commented May 20, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2020
@knobunc
Copy link
Contributor

knobunc commented May 20, 2020

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: frobware, knobunc, Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2020
@openshift-merge-robot openshift-merge-robot merged commit 89624b6 into openshift:master May 20, 2020
@openshift-ci-robot
Copy link

@frobware: All pull requests linked via external trackers have merged: openshift/origin#24976. Bugzilla bug 1834343 has been moved to the MODIFIED state.

In response to this:

Bug 1834343: router: Re-enable h2spec and grpc-interop e2e tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Miciah Miciah Miciah left review comments

@gabemontero gabemontero Awaiting requested review from gabemontero

@knobunc knobunc Awaiting requested review from knobunc

@danehans danehans Awaiting requested review from danehans

Assignees

@Miciah Miciah

@knobunc knobunc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@frobware @openshift-ci-robot @Miciah @knobunc @openshift-merge-robot