Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1841315: reenable jenkins e2e in e2e-gcp-builds #25033

Conversation

gabemontero
Copy link
Contributor

@akram @waveywaves FYI

with the verification on https://bugzilla.redhat.com/show_bug.cgi?id=1783530 earlier this month, the path to re-enablement of these tests in OCP's build and conformance suites in openshift/origin and openshift/* repos with those suites seems prudent

quick reminder, the pipeline_jenkins_e2e.go tests still run when you all create PRs in the openshift/jenkins* repos.

let's see how they look

@adambkaplan @coreydaley FYI

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 27, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2020
@gabemontero
Copy link
Contributor Author

/retest

@gabemontero
Copy link
Contributor Author

/test e2e-gcp-builds

@gabemontero
Copy link
Contributor Author

the wait for jenkins to come up step is failing ... the attempts to curl jenkins from the execpod are getting:

# Test: 0
rc=0
: > /tmp/body /tmp/headers
curl -X GET -H "Authorization:Bearer XIE7zT0pRq6zuY_I-1RfegAAAAAAAAAA"  -s -S -o /tmp/body -D /tmp/headers "http://172.30.78.84:80/" -w '{"code":%{http_code}}' 2>/tmp/error 1>/tmp/output || rc=$?
echo "{\"test\":0,\"rc\":$(echo $rc),\"curl\":$(cat /tmp/output),\"error\":$(cat /tmp/error | json_escape),\"body\":\"$(cat /tmp/body | base64 -w 0 -)\",\"headers\":$(cat /tmp/headers | json_escape)}"'
May 27 14:24:30.445: INFO: stderr: "+ set -euo pipefail\n+ rc=0\n+ : /tmp/headers\n+ curl -X GET -H Authorization:Bearer XIE7zT0pRq6zuY_I-1RfegAAAAAAAAAA -s -S -o /tmp/body -D /tmp/headers http://172.30.78.84:80/ -w {\"code\":%{http_code}}\n+ echo 0\n+ cat /tmp/output\n+ cat /tmp/error\n+ json_escape\n+ python -c import json,sys; print json.dumps(sys.stdin.read())\n/bin/sh: python: not found\n+ cat /tmp/body\n+ base64 -w 0 -\nbase64: unrecognized option: w\nBusyBox v1.26.2 (2018-05-30 13:51:20 GMT) multi-call binary.\n\nUsage: base64 [-d] [FILE]\n\nBase64 encode or decode FILE to standard output\n\t-d\tDecode data\n+ cat /tmp/headers\n+ json_escape\n+ python -c import json,sys; print json.dumps(sys.stdin.read())\n/bin/sh: python: not found\n+ echo {\"test\":0,\"rc\":0,\"curl\":{\"code\":200},\"error\":,\"body\":\"\",\"headers\":}\n"
May 27 14:24:30.445: INFO: stdout: "{\"test\":0,\"rc\":0,\"curl\":{\"code\":200},\"error\":,\"body\":\"\",\"headers\":}\n"
May 27 14:24:30.445: INFO: Error accessing resource: &errors.errorString{s:"response 0 could not be decoded: invalid character ',' looking for beginning of value"}
May 27 14:24:39.936: INFO: Retrieving Jenkins resource: "http://172.30.78.84:80/"
May 27 14:24:39.936: INFO: Running '/usr/bin/kubectl --server=https://api.ci-op-ylq9l9wy-139dc.origin-ci-int-aws.dev.rhcloud.com:6443 --kubeconfig=/tmp/admin.kubeconfig exec --namespace=e2e-test-jenkins-pipeline-dgffr execpod -- /bin/sh -x -c set -euo pipefail
function json_escape() {
  python -c 'import json,sys; print json.dumps(sys.stdin.read())'
}

the dump of the jenkins pod when this times out did not kick in

I'll see about sorting that out and see if we can see what is going on inside the jenkins pod.

@akram @waveywaves FYI

@gabemontero
Copy link
Contributor Author

So the example pipeline https://github.com/openshift/jenkins-client-plugin/blob/master/examples/jenkins-image-sample.groovy used in the e2e's no longer seems functional @akram @waveywaves

[rollout:status:deploymentconfig/jenkins-second-deployment] Error from server (NotFound): deploymentconfigs.apps.openshift.io "jenkins-second-deployment" not found
[Pipeline] }
[Pipeline] // node
[Pipeline] }
[Pipeline] // timeout
[Pipeline] echo
in catch block
[Pipeline] echo
Caught: hudson.AbortException: rollout:status returned an error;
{reference={}, err=Error from server (NotFound): deploymentconfigs.apps.openshift.io "jenkins-second-deployment" not found
, verb=rollout, cmd=oc --server=https://172.30.0.1:443 --certificate-authority=/var/run/secrets/kubernetes.io/serviceaccount/ca.crt --namespace=e2e-test-jenkins-pipeline-9kznn --token=XXXXX rollout status deploymentconfig/jenkins-second-deployment -w , out=, status=1}

[Pipeline] End of Pipeline
ERROR: rollout:status returned an error;
{reference={}, err=Error from server (NotFound): deploymentconfigs.apps.openshift.io "jenkins-second-deployment" not found
, verb=rollout, cmd=oc --server=https://172.30.0.1:443 --certificate-authority=/var/run/secrets/kubernetes.io/serviceaccount/ca.crt --namespace=e2e-test-jenkins-pipeline-9kznn --token=XXXXX rollout status deploymentconfig/jenkins-second-deployment -w , out=, status=1}

Finished: FAILURE

Are you guys aware of this?

I'll start debugging in the interim.

@gabemontero gabemontero changed the title WIP: reenable jenkins e2e in e2e-gcp-builds and conformance given jdk11 oauth fix Bug 1841315: reenable jenkins e2e in e2e-gcp-builds and conformance given jdk11 oauth fix May 28, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels May 28, 2020
@openshift-ci-robot
Copy link

@gabemontero: This pull request references Bugzilla bug 1841315, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1841315: reenable jenkins e2e in e2e-gcp-builds and conformance given jdk11 oauth fix

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gabemontero
Copy link
Contributor Author

/test e2e-cmd
/test e2e-gcp

@gabemontero gabemontero force-pushed the reenable-jenkins-e2e-bld-conformance branch 2 times, most recently from 6cdc3b5 to 9c89b88 Compare May 29, 2020 12:09
@gabemontero
Copy link
Contributor Author

OK we have clean tests jenkins tests in e2e-gcp-builds @akram @waveywaves @adambkaplan @coreydaley

[sig-builds][Feature:Builds][sig-devex][Feature:Jenkins][Slow]  openshift pipeline build Sync plugin tests using the ephemeral template  [Suite:openshift] | 10m39s
-- | --
[sig-builds][Feature:Builds][sig-devex][Feature:Jenkins][Slow]  openshift pipeline build jenkins-client-plugin tests using the  ephemeral template [Suite:openshift] | 8m24s
-- | --

I'll squash / clean up the commits and then assign to some for lgtm

@gabemontero gabemontero force-pushed the reenable-jenkins-e2e-bld-conformance branch from 9c89b88 to 71ed2c2 Compare May 29, 2020 17:01
@gabemontero gabemontero changed the title Bug 1841315: reenable jenkins e2e in e2e-gcp-builds and conformance given jdk11 oauth fix Bug 1841315: reenable jenkins e2e in e2e-gcp-builds May 29, 2020
@gabemontero
Copy link
Contributor Author

/assign @coreydaley

@gabemontero gabemontero force-pushed the reenable-jenkins-e2e-bld-conformance branch from 71ed2c2 to f7bda41 Compare May 29, 2020 19:44
@gabemontero
Copy link
Contributor Author

update pushed @coreydaley

@gabemontero gabemontero force-pushed the reenable-jenkins-e2e-bld-conformance branch from f7bda41 to c4b8108 Compare May 29, 2020 19:48
@gabemontero
Copy link
Contributor Author

update again pushed @coreydaley

@coreydaley
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 29, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: coreydaley, gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: coreydaley, gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit a637491 into openshift:master May 30, 2020
@openshift-ci-robot
Copy link

@gabemontero: All pull requests linked via external trackers have merged: openshift/origin#25033, openshift/jenkins-client-plugin#330. Bugzilla bug 1841315 has been moved to the MODIFIED state.

In response to this:

Bug 1841315: reenable jenkins e2e in e2e-gcp-builds

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gabemontero gabemontero deleted the reenable-jenkins-e2e-bld-conformance branch May 30, 2020 03:42
@gabemontero
Copy link
Contributor Author

/cherrypick release-4.4

@openshift-cherrypick-robot

@gabemontero: new pull request created: #25128

In response to this:

/cherrypick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@akram
Copy link
Contributor

akram commented Jun 19, 2020

@gabemontero openshift/jenkins-client-plugin#334 should have fixed some remaining issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants