Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1845369: UPSTREAM: 91500: reduce race risk in kubelet for missing KUBERNETES_SERVICE_HOST #25127

Merged
merged 1 commit into from Jun 17, 2020
Merged

Bug 1845369: UPSTREAM: 91500: reduce race risk in kubelet for missing KUBERNETES_SERVICE_HOST #25127

merged 1 commit into from Jun 17, 2020

Conversation

rphillips
Copy link
Contributor

recreated from: #25079

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label Jun 16, 2020
@openshift-ci-robot
Copy link

@rphillips: This pull request references Bugzilla bug 1845369, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1839098 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Bugzilla bug 1839098 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
  • bug has dependents

In response to this:

Bug 1845369: UPSTREAM: 91500: reduce race risk in kubelet for missing KUBERNETES_SERVICE_HOST

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jun 16, 2020
@openshift-ci-robot openshift-ci-robot added the vendor-update Touching vendor dir or related files label Jun 16, 2020
@rphillips
Copy link
Contributor Author

/retest

@tnozicka
Copy link
Contributor

https://deck-ci.apps.ci.l2s4.p1.openshiftapps.com/view/gcs/origin-ci-test/pr-logs/pull/25127/pull-ci-openshift-origin-release-4.5-images/1272901875758272512#1:build-log.txt%3A78
builds are broken because CI configs moved golang back to 1.12, there is openshift/release#9696

@mrunalp mrunalp added the staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). label Jun 16, 2020
@tnozicka
Copy link
Contributor

tnozicka commented Jun 16, 2020 •
edited

we have also in parallel fixed just the openshift-test image, that's merged by now though #25122
(but that isn't in 4.5, so the revert may be easier then going through the backport porcess)

@nee1esh
Copy link

nee1esh commented Jun 16, 2020

/retest

@sjenning
Copy link
Contributor

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rphillips, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

12 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@sjenning
Copy link
Contributor

/override ci/prow/e2e-aws-disruptive
/override ci/prow/e2e-conformance-k8s

@openshift-ci-robot
Copy link

@sjenning: Overrode contexts on behalf of sjenning: ci/prow/e2e-aws-disruptive, ci/prow/e2e-conformance-k8s

In response to this:

/override ci/prow/e2e-aws-disruptive
/override ci/prow/e2e-conformance-k8s

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sjenning
Copy link
Contributor

/override ci/prow/e2e-conformance-k8s

@openshift-ci-robot
Copy link

@sjenning: Overrode contexts on behalf of sjenning: ci/prow/e2e-conformance-k8s

In response to this:

/override ci/prow/e2e-conformance-k8s

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rphillips
Copy link
Contributor Author

/retest

@sjenning
Copy link
Contributor

/test e2e-aws-image-registry
/test e2e-aws-jenkins

@openshift-merge-robot openshift-merge-robot merged commit 844f20b into openshift:release-4.5 Jun 17, 2020
@openshift-ci-robot
Copy link

@rphillips: All pull requests linked via external trackers have merged: openshift/origin#25127. Bugzilla bug 1845369 has been moved to the MODIFIED state.

In response to this:

Bug 1845369: UPSTREAM: 91500: reduce race risk in kubelet for missing KUBERNETES_SERVICE_HOST

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjenning sjenning Awaiting requested review from sjenning

@tbielawa tbielawa Awaiting requested review from tbielawa

Assignees

@sjenning sjenning

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). vendor-update Touching vendor dir or related files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@rphillips @openshift-ci-robot @tnozicka @nee1esh @sjenning @openshift-bot @mrunalp @openshift-merge-robot