Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-3.11] Bug 1760807: UPSTREAM: <carry>: Enforce label selector validation in scheduler podAffinity #25350

Merged
merged 1 commit into from
Aug 19, 2020
Merged

[release-3.11] Bug 1760807: UPSTREAM: <carry>: Enforce label selector validation in scheduler podAffinity #25350

merged 1 commit into from
Aug 19, 2020

Conversation

damemi
Copy link

@damemi damemi commented Jul 30, 2020 •
edited

This is a non-breaking version of #24616

The goal of this is to validate Pod affinitys before the pod is scheduled and reject the pod if there is an invalid value. Without this check, the invalid pod will be scheduled and all subsequent pods will fail to schedule when attempting to parse the invalid value.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jul 30, 2020
@openshift-ci-robot
Copy link

@damemi: This pull request references Bugzilla bug 1760807, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (3.11.z) matches configured target release for branch (3.11.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1760807: UPSTREAM: : Enforce label selector validation in scheduler podAffinity

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@damemi
Copy link
Author

damemi commented Jul 30, 2020

/hold
need to test this in a 3.11 cluster

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 30, 2020
@openshift-ci-robot
Copy link

@damemi: This pull request references Bugzilla bug 1760807, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (3.11.z) matches configured target release for branch (3.11.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1760807: UPSTREAM: : Enforce label selector validation in scheduler podAffinity

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@damemi damemi mentioned this pull request Jul 30, 2020
Closed
@openshift-ci-robot
Copy link

@damemi: This pull request references Bugzilla bug 1760807, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (3.11.z) matches configured target release for branch (3.11.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1760807: UPSTREAM: : Enforce label selector validation in scheduler podAffinity

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@damemi damemi changed the title Bug 1760807: UPSTREAM: <carry>: Enforce label selector validation in scheduler podAffinity [release-3.11] Bug 1760807: UPSTREAM: <carry>: Enforce label selector validation in scheduler podAffinity Jul 30, 2020
@damemi
Copy link
Author

damemi commented Jul 30, 2020

/retest

2 similar comments
@damemi
Copy link
Author

damemi commented Jul 31, 2020

/retest

@damemi
Copy link
Author

damemi commented Aug 4, 2020

/retest

@damemi damemi force-pushed the 3.11-upstream-label-selector branch from 0a062c7 to 3b65469 Compare August 12, 2020 20:43
@damemi
Copy link
Author

damemi commented Aug 12, 2020

/hold cancel
I didn't get a 3.11 cluster to manually test this, but did add unit tests which actually showed this wasn't originally always catching the error. Refactored it and it's not elegant, but it does get the job done and catches the error appropriately.

@soltysh could you ptal?

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 12, 2020
@damemi
Copy link
Author

damemi commented Aug 12, 2020

/retest

3 similar comments
@damemi
Copy link
Author

damemi commented Aug 13, 2020

/retest

@damemi
Copy link
Author

damemi commented Aug 13, 2020

/retest

@damemi
Copy link
Author

damemi commented Aug 13, 2020

/retest

@damemi
Copy link
Author

damemi commented Aug 13, 2020 

FAIL: github.com/openshift/origin/pkg/build/builder TestDockerfilePath 20ms
FAIL: github.com/openshift/origin/pkg/build/builder TestDockerfileFromScratch 10ms
FAIL: github.com/openshift/origin/pkg/build/builder TestDockerBuildError 0s
FAIL: github.com/openshift/origin/pkg/build/builder TestPushError 0s
FAIL: github.com/openshift/origin/pkg/build/builder TestGetStrategyError 0s

Don't think these are related to my changes at all
/retest

@mfojtik
Copy link
Member

mfojtik commented Aug 17, 2020

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 17, 2020
@mfojtik
Copy link
Member

mfojtik commented Aug 17, 2020

/retest

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damemi, mfojtik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 17, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

19 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit dc045cb into openshift:release-3.11 Aug 19, 2020
@openshift-ci-robot
Copy link

@damemi: All pull requests linked via external trackers have merged: openshift/origin#25350. Bugzilla bug 1760807 has been moved to the MODIFIED state.

In response to this:

[release-3.11] Bug 1760807: UPSTREAM: : Enforce label selector validation in scheduler podAffinity

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@damemi damemi mentioned this pull request Sep 2, 2020
Merged
@damemi damemi mentioned this pull request Jan 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@tbielawa tbielawa Awaiting requested review from tbielawa

Assignees

@mfojtik mfojtik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@damemi @openshift-ci-robot @mfojtik @openshift-bot @openshift-merge-robot