Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1890141: move off docker.io in templates/builds/jenkins tests #25595

Merged
merged 2 commits into from Oct 21, 2020

Conversation

gabemontero
Copy link
Contributor

@openshift/openshift-team-build-api FYI

@sbose78 this PR currently assumes we can push docker.io/openshift/test-build-simples2i:latest to quay.io/redhat-developer/test-build-simples2i:latest

/assign @adambkaplan

@sbose78
Copy link

sbose78 commented Oct 8, 2020

That was quick, thank you Gabe!

@openshift-ci-robot
Copy link

@gabemontero: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-fips 8d27e17 link /test e2e-aws-fips
ci/prow/e2e-gcp 8d27e17 link /test e2e-gcp
ci/prow/e2e-gcp-builds 8d27e17 link /test e2e-gcp-builds

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gabemontero
Copy link
Contributor Author

Other than the aforementioned quay.io/redhat-developer/test-build-simples2i:latest not existing yet, this look OK so far e2e wise.
Or at least that is the vast majority of failures.

@sbose78 @adambkaplan - do either of your have to authority to create such a repo in quay.io/redhat-developer so I can push to it like I did with the recent jenkins e2e PR that merged ?

@gabemontero
Copy link
Contributor Author

ok @adambkaplan has created quay.io/redhat-developer/test-build-simples2i:latest

/retest

@gabemontero
Copy link
Contributor Author

OK I think we are down to multistage.go failing consistently ... the switch to quay.io/fedora/fedora:34-x86_64 does not seem to be happy (though it is not an image pull thing).

gonna try registry.access.redhat.com/rhel7 instead (since this is a from via dockerfile test, not going to do registry.redhat.io)

@gabemontero
Copy link
Contributor Author

/retest

@gabemontero
Copy link
Contributor Author

OK @adambkaplan we are running clean (enough - I believe the e2e-cmd errors are non related flakes) with this move off of docker.io images

PTAL

/retest

@gabemontero
Copy link
Contributor Author

Also @adambkaplan I'm thinking we should open/associate a BZ with this and backport to releases we still actively maintain (and I shudder to say ... 3.11 even)

thoughts?

@gabemontero
Copy link
Contributor Author

again unrelated cmd flakes ... cmds that failed different than last run

/retest

@gabemontero
Copy link
Contributor Author

There might be a known oc bug related to the recent e2e-cmd errors. I've reached out to Maciej for opinions.

Note, this test did pass back with https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/25595/pull-ci-openshift-origin-master-e2e-cmd/1314302332669792256 on Oct 8 .... I'm still of the belief that nothing in this PR would have lead to the subsequent failed runs.

@coreydaley
Copy link
Member

/retest

@gabemontero gabemontero changed the title move off docker.io in templates/builds/jenkins tests Bug 1890141: move off docker.io in templates/builds/jenkins tests Oct 21, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Oct 21, 2020
@openshift-ci-robot
Copy link

@gabemontero: This pull request references Bugzilla bug 1890141, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1890141: move off docker.io in templates/builds/jenkins tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good.

I have a concern about using registry.redhat.io - will this present a challenge backporting to 4.4 and 3.11? Do you plan on using registry.access.redhat.com for those?

I think moving forward registry.redhat.io is the right host for Red Hat images, since registry.access.redhat.com is somewhat deprecated.

@adambkaplan
Copy link
Contributor

/approve

@gabemontero
Copy link
Contributor Author

Generally looks good.

I have a concern about using registry.redhat.io - will this present a challenge backporting to 4.4 and 3.11? Do you plan on using registry.access.redhat.com for those?

I think moving forward registry.redhat.io is the right host for Red Hat images, since registry.access.redhat.com is somewhat deprecated.

exactly ... my general plan is to use the TBR until I can't but of course as a result that will entail manual cherrypicks vs. the bot

@gabemontero
Copy link
Contributor Author

different set of cmd test failures with https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/25595/pull-ci-openshift-origin-master-e2e-cmd/1318905854161850368

this time just timeout connecting to api server flakes

still unrelated to these changes

/retest

@gabemontero
Copy link
Contributor Author

@adambkaplan we have managed to avoid e2e-cmd flakes ... all tests green ... how about an lgtm

oh, and based on the files touched, also need an approval from

/assign @bparees

for https://github.com/openshift/origin/blob/master/test/OWNERS

to complete this move off of docker.io images

@bparees
Copy link
Contributor

bparees commented Oct 21, 2020

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2020
Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, bparees, gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot
Copy link
Contributor

@gabemontero: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-csi 696f71a link /test e2e-aws-csi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 377fde6 into openshift:master Oct 21, 2020
@openshift-ci-robot
Copy link

@gabemontero: All pull requests linked via external trackers have merged:

Bugzilla bug 1890141 has been moved to the MODIFIED state.

In response to this:

Bug 1890141: move off docker.io in templates/builds/jenkins tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gabemontero gabemontero deleted the docker-io-refs branch October 22, 2020 12:43
@gabemontero
Copy link
Contributor Author

/cherrypick release-4.6

@openshift-cherrypick-robot

@gabemontero: new pull request created: #25622

In response to this:

/cherrypick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants