New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1890141: move off docker.io in templates/builds/jenkins tests #25595
Bug 1890141: move off docker.io in templates/builds/jenkins tests #25595
Conversation
That was quick, thank you Gabe! |
@gabemontero: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Other than the aforementioned @sbose78 @adambkaplan - do either of your have to authority to create such a repo in quay.io/redhat-developer so I can push to it like I did with the recent jenkins e2e PR that merged ? |
ok @adambkaplan has created /retest |
OK I think we are down to multistage.go failing consistently ... the switch to gonna try |
8d27e17
to
fb2b758
Compare
/retest |
OK @adambkaplan we are running clean (enough - I believe the e2e-cmd errors are non related flakes) with this move off of docker.io images PTAL /retest |
Also @adambkaplan I'm thinking we should open/associate a BZ with this and backport to releases we still actively maintain (and I shudder to say ... 3.11 even) thoughts? |
again unrelated cmd flakes ... cmds that failed different than last run /retest |
There might be a known Note, this test did pass back with https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/25595/pull-ci-openshift-origin-master-e2e-cmd/1314302332669792256 on Oct 8 .... I'm still of the belief that nothing in this PR would have lead to the subsequent failed runs. |
/retest |
@gabemontero: This pull request references Bugzilla bug 1890141, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good.
I have a concern about using registry.redhat.io
- will this present a challenge backporting to 4.4 and 3.11? Do you plan on using registry.access.redhat.com
for those?
I think moving forward registry.redhat.io
is the right host for Red Hat images, since registry.access.redhat.com
is somewhat deprecated.
/approve |
exactly ... my general plan is to use the TBR until I can't but of course as a result that will entail manual cherrypicks vs. the bot |
different set of cmd test failures with https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/25595/pull-ci-openshift-origin-master-e2e-cmd/1318905854161850368 this time just timeout connecting to api server flakes still unrelated to these changes /retest |
@adambkaplan we have managed to avoid e2e-cmd flakes ... all tests green ... how about an lgtm oh, and based on the files touched, also need an approval from /assign @bparees for https://github.com/openshift/origin/blob/master/test/OWNERS to complete this move off of docker.io images |
/approve |
fb2b758
to
696f71a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan, bparees, gabemontero The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@gabemontero: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@gabemontero: All pull requests linked via external trackers have merged: Bugzilla bug 1890141 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick release-4.6 |
@gabemontero: new pull request created: #25622 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@openshift/openshift-team-build-api FYI
@sbose78 this PR currently assumes we can push
docker.io/openshift/test-build-simples2i:latest
toquay.io/redhat-developer/test-build-simples2i:latest
/assign @adambkaplan