Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle cases where pod sandboxes fail after pod deletion #25610

Merged
merged 1 commit into from Oct 20, 2020
Merged

handle cases where pod sandboxes fail after pod deletion #25610

merged 1 commit into from Oct 20, 2020

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Oct 15, 2020

  1. if pod sandbox creation fails before deletion, fail.
  2. if pod sandbox creation fails within one second of deletion, allow grace.
  3. if pod sandbox creation fails within five seconds of deletion, flake
  4. if pod sandbox creation fails more than five seconds after deletion, fail.

@deads2k
Copy link
Contributor Author

deads2k commented Oct 15, 2020

/cherrypick release-4.6

@openshift-cherrypick-robot
Copy link

@deads2k: once the present PR merges, I will cherry-pick it on top of release-4.6 in a new PR and assign it to you.

In response to this:

/cherrypick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 15, 2020
@aojea
Copy link
Contributor

aojea commented Oct 15, 2020

/cc

@sttts
Copy link
Contributor

sttts commented Oct 19, 2020

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 19, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 54e482e into openshift:master Oct 20, 2020
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 20, 2020
Closed
@openshift-cherrypick-robot
Copy link

@deads2k: new pull request created: #25612

In response to this:

/cherrypick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bparees bparees Awaiting requested review from bparees

@spadgett spadgett Awaiting requested review from spadgett

@aojea aojea Awaiting requested review from aojea

Assignees

@sttts sttts

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@deads2k @openshift-cherrypick-robot @aojea @sttts @openshift-ci-robot @openshift-bot @openshift-merge-robot