Bug 1882556: Access git over https for tests #25625

coreydaley · 2020-10-23T01:03:05Z

Replace git:// urls with https:// urls for all tests

openshift-ci-robot · 2020-10-23T01:03:12Z

@coreydaley-redhat: This pull request references Bugzilla bug 1882556, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.0) matches configured target release for branch (4.7.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1882556: Access git over https for tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

coreydaley · 2020-10-23T01:03:48Z

/assign @adambkaplan

coreydaley · 2020-10-23T13:23:09Z

/retest

adambkaplan

I'd like to ensure that we have at least one e2e test that pulls via the git: protocol. This test would need to check that we have a cluster-wide proxy configured before running.

coreydaley · 2020-10-25T22:16:27Z

I'd like to ensure that we have at least one e2e test that pulls via the git: protocol. This test would need to check that we have a cluster-wide proxy configured before running.

So, we would need to fix the proxy (according to the bugzilla) so that git:// urls can be proxied. Should that be a JIRA then as it is probably a bit more work. Or are you saying that we need a test that uses a git:// url and make sure that the proxy is NOT configured so that it has a chance to work?

adambkaplan · 2020-10-27T16:55:58Z

Or are you saying that we need a test that uses a git:// url and make sure that the proxy is NOT configured so that it has a chance to work?

Correct - we should have a test that clones source via git://, but when the test starts it checks if a proxy has been configured, skipping if a proxy is present. This should be fairly straightforward (psudo-code here):

func hasProxy() (bool, error) {
    proxy, err := e.ConfigClient.Proxies().Get(ctx, "cluster", metav1.GetOptions{})
    if err != nil && !kerrors.IsNotFound(err) {
        return false, error
    }
    if kerrors.IsNotFound(err) {
        return false, nil
    }
    return len(proxy.Status.HTTPProxy) > 0 || len(proxy.Status.HTTPSProxy) > 0, nil
}

coreydaley · 2020-10-27T19:44:36Z

/retest

coreydaley · 2020-10-27T20:27:41Z

/retest

coreydaley · 2020-10-28T02:25:45Z

/retest

wewang58 · 2020-10-28T08:21:36Z

/bugzilla cc-qa

openshift-ci-robot · 2020-10-28T08:21:40Z

@wewang58: This pull request references Bugzilla bug 1882556, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.0) matches configured target release for branch (4.7.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @wewang58

In response to this:

/bugzilla cc-qa

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

coreydaley · 2020-10-28T11:57:34Z

@adambkaplan ptal

adambkaplan

/approve

Minor suggestions, otherwise looks good.

test/extended/builds/clone_git_protocol.go

test/extended/util/proxy.go

coreydaley · 2020-10-28T16:25:42Z

@adambkaplan all suggestions have been applied, ptal

adambkaplan

/lgtm

coreydaley · 2020-10-28T19:26:48Z

/retest

coreydaley · 2020-10-28T23:57:01Z

/assign @soltysh

wewang58 · 2020-10-29T01:37:41Z

Using cluster-bot to launch cluster to test it
/lgtm

soltysh

/lgtm cancel

test/extended/builds/clone_git_protocol.go

Replace git:// urls with https:// urls for all tests

coreydaley · 2020-10-29T12:21:58Z

@soltysh Updated per your comment, ptal.

soltysh

/lgtm
/approve

openshift-ci-robot · 2020-10-29T12:27:21Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, coreydaley-redhat, soltysh, wewang58

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~examples/sample-app/OWNERS~~ [adambkaplan,soltysh]
~~test/OWNERS~~ [soltysh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2020-10-29T13:37:23Z

@coreydaley-redhat: All pull requests linked via external trackers have merged:

openshift/origin#25625

Bugzilla bug 1882556 has been moved to the MODIFIED state.

In response to this:

Bug 1882556: Access git over https for tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

The issue this was working around should be fixed [1,2]. [1]: openshift/origin#25625 [2]: https://bugzilla.redhat.com/show_bug.cgi?id=1882556#c5

adambkaplan · 2021-03-09T15:15:32Z

/cherrypick release-4.6

adambkaplan · 2021-03-09T15:18:09Z

/cherry-pick release-4.6

openshift-cherrypick-robot · 2021-03-09T15:18:28Z

@adambkaplan: new pull request created: #25951

In response to this:

/cherrypick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

adambkaplan · 2021-03-09T15:19:06Z

/cherry-pick release-4.5

openshift-cherrypick-robot · 2021-03-09T15:19:09Z

@adambkaplan: new pull request could not be created: failed to create pull request against openshift/origin#release-4.6 from head openshift-cherrypick-robot:cherry-pick-25625-to-release-4.6: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for openshift-cherrypick-robot:cherry-pick-25625-to-release-4.6."}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"}

In response to this:

/cherry-pick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2021-03-09T15:19:53Z

@adambkaplan: #25625 failed to apply on top of branch "release-4.5":

Applying: Bug 1882556: Access git over https for tests
Using index info to reconstruct a base tree...
M	test/extended/testdata/bindata.go
M	test/extended/testdata/cmd/test/cmd/env.sh
M	test/extended/util/annotate/generated/zz_generated.annotations.go
Falling back to patching base and 3-way merge...
Auto-merging test/extended/util/annotate/generated/zz_generated.annotations.go
CONFLICT (content): Merge conflict in test/extended/util/annotate/generated/zz_generated.annotations.go
Auto-merging test/extended/testdata/cmd/test/cmd/env.sh
Auto-merging test/extended/testdata/bindata.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Bug 1882556: Access git over https for tests
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Oct 23, 2020

openshift-ci-robot requested review from adambkaplan and csrwng October 23, 2020 01:03

openshift-ci-robot assigned adambkaplan Oct 23, 2020

adambkaplan reviewed Oct 23, 2020

View reviewed changes

openshift-ci-robot requested a review from wewang58 October 28, 2020 08:21

adambkaplan reviewed Oct 28, 2020

View reviewed changes

test/extended/builds/clone_git_protocol.go Outdated Show resolved Hide resolved

test/extended/builds/clone_git_protocol.go Outdated Show resolved Hide resolved

test/extended/util/proxy.go Outdated Show resolved Hide resolved

adambkaplan reviewed Oct 28, 2020

View reviewed changes

test/extended/util/proxy.go Outdated Show resolved Hide resolved

adambkaplan approved these changes Oct 28, 2020

View reviewed changes

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2020

openshift-ci-robot assigned soltysh Oct 28, 2020

openshift-ci-robot assigned wewang58 Oct 29, 2020

soltysh requested changes Oct 29, 2020

View reviewed changes

test/extended/builds/clone_git_protocol.go Outdated Show resolved Hide resolved

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2020

Bug 1882556: Access git over https for tests

e4aa793

Replace git:// urls with https:// urls for all tests

soltysh approved these changes Oct 29, 2020

View reviewed changes

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 29, 2020

openshift-merge-robot merged commit 1bc6351 into openshift:master Oct 29, 2020

wking mentioned this pull request Nov 9, 2020

ci-operator/step-registry/openshift/e2e/aws/proxy: Drop build skip openshift/release#13503

Merged

openshift-cherrypick-robot mentioned this pull request Mar 9, 2021

[release-4.6] Bug 1936974: Access git over https for tests #25951

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 1882556: Access git over https for tests #25625

Bug 1882556: Access git over https for tests #25625

coreydaley commented Oct 23, 2020

openshift-ci-robot commented Oct 23, 2020

coreydaley commented Oct 23, 2020

coreydaley commented Oct 23, 2020

adambkaplan left a comment

coreydaley commented Oct 25, 2020

adambkaplan commented Oct 27, 2020

coreydaley commented Oct 27, 2020

coreydaley commented Oct 27, 2020

coreydaley commented Oct 28, 2020

wewang58 commented Oct 28, 2020

openshift-ci-robot commented Oct 28, 2020

coreydaley commented Oct 28, 2020

adambkaplan left a comment

coreydaley commented Oct 28, 2020

adambkaplan left a comment

coreydaley commented Oct 28, 2020

coreydaley commented Oct 28, 2020

wewang58 commented Oct 29, 2020

soltysh left a comment

coreydaley commented Oct 29, 2020

soltysh left a comment

openshift-ci-robot commented Oct 29, 2020

openshift-ci-robot commented Oct 29, 2020

adambkaplan commented Mar 9, 2021

adambkaplan commented Mar 9, 2021

openshift-cherrypick-robot commented Mar 9, 2021

adambkaplan commented Mar 9, 2021

openshift-cherrypick-robot commented Mar 9, 2021

openshift-cherrypick-robot commented Mar 9, 2021

Bug 1882556: Access git over https for tests #25625

Bug 1882556: Access git over https for tests #25625

Conversation

coreydaley commented Oct 23, 2020

openshift-ci-robot commented Oct 23, 2020

coreydaley commented Oct 23, 2020

coreydaley commented Oct 23, 2020

adambkaplan left a comment

Choose a reason for hiding this comment

coreydaley commented Oct 25, 2020

adambkaplan commented Oct 27, 2020

coreydaley commented Oct 27, 2020

coreydaley commented Oct 27, 2020

coreydaley commented Oct 28, 2020

wewang58 commented Oct 28, 2020

openshift-ci-robot commented Oct 28, 2020

coreydaley commented Oct 28, 2020

adambkaplan left a comment

Choose a reason for hiding this comment

coreydaley commented Oct 28, 2020

adambkaplan left a comment

Choose a reason for hiding this comment

coreydaley commented Oct 28, 2020

coreydaley commented Oct 28, 2020

wewang58 commented Oct 29, 2020

soltysh left a comment

Choose a reason for hiding this comment

coreydaley commented Oct 29, 2020

soltysh left a comment

Choose a reason for hiding this comment

openshift-ci-robot commented Oct 29, 2020

openshift-ci-robot commented Oct 29, 2020

adambkaplan commented Mar 9, 2021

adambkaplan commented Mar 9, 2021

openshift-cherrypick-robot commented Mar 9, 2021

adambkaplan commented Mar 9, 2021

openshift-cherrypick-robot commented Mar 9, 2021

openshift-cherrypick-robot commented Mar 9, 2021