New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move debug.sh & timeout.sh to a proper e2e #25638
Conversation
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sallyom, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-4.9 |
Looks like backporting this will solve https://bugzilla.redhat.com/show_bug.cgi?id=1998963 |
@hardys: #25638 failed to apply on top of branch "release-4.9":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@hardys you'll likely need to pick manually what you care about since that's one of many PRs rewriting the tests, so it might not be that simple to backport 馃槥 |
In comparison with the original I:
--keep-readiness
and--keep-liveness
b/c they were checking empty string/assign @sallyom