Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable cakephp while cuppett/scl sort out new upstream regression #25640

Merged

Conversation

gabemontero
Copy link
Contributor

/hold

for now ... tracking upstream efforts into resolving this ... if too far out, will pull the trigger here

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 27, 2020
@gabemontero
Copy link
Contributor Author

image-eco passed, other e2e failures unrelated flakes

@cuppett was able to tweak https://github.com/sclorg/cakephp-ex to work around the regresssion, but we are still awaiting feedback from the scl team on how/what parts of what he provided they want to pull in ... based on delays etc. we may want to merge this for short term relief, and then revert it when some form of @cuppett 's fix has landed

@adambkaplan fyi

also, for tracking purposes, I opened https://bugzilla.redhat.com/show_bug.cgi?id=1891989 on the scl team

/retest

@gabemontero
Copy link
Contributor Author

gabemontero commented Oct 28, 2020

all green tests

/hold cancel

/assign @adambkaplan

IMO let's pull the trigger on this if the upstream cakephp issue is not resolved by the type we are ready to merge BUILD-125 or one of our other in flight PRs

WDYT @adambkaplan

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 28, 2020
Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Let's merge this, and when the upstream issue is fixed we revert this PR.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 28, 2020
@openshift-merge-robot openshift-merge-robot merged commit d746cec into openshift:master Oct 28, 2020
@gabemontero gabemontero deleted the disable-cakephp-master branch October 28, 2020 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants