apiserver: remove terminates kube-apiserver gracefully test #25720
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposes removing the
kubelet terminates kube-apiserver gracefully
test. watch-termination does not use a flock to protect concurrent access to the log and lockfile. We changed the static pod UIDs to include an updated UID when they change, so the kubelet starts deleting UID1, while UID2 is starting.Additionally, there is a case where apiserver is exiting with a 1 exit code. The test case looks at the entire event history looking for a NonGracefulTermination. This is problematic when there is a case where the exit code of 1 is triggered.
watch-termination logs: https://bugzilla.redhat.com/show_bug.cgi?id=1882750#c31
Either the test, exit code strategy, or watch-termination application need to be updated to account for these scenarios.
cc @sttts @deads2k