Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apiserver: remove terminates kube-apiserver gracefully test #25720

Closed

Conversation

rphillips
Copy link
Contributor

@rphillips rphillips commented Nov 30, 2020

This proposes removing the kubelet terminates kube-apiserver gracefully test. watch-termination does not use a flock to protect concurrent access to the log and lockfile. We changed the static pod UIDs to include an updated UID when they change, so the kubelet starts deleting UID1, while UID2 is starting.

Additionally, there is a case where apiserver is exiting with a 1 exit code. The test case looks at the entire event history looking for a NonGracefulTermination. This is problematic when there is a case where the exit code of 1 is triggered.

watch-termination logs: https://bugzilla.redhat.com/show_bug.cgi?id=1882750#c31

Either the test, exit code strategy, or watch-termination application need to be updated to account for these scenarios.

cc @sttts @deads2k

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rphillips
To complete the pull request process, please assign knobunc after the PR has been reviewed.
You can assign the PR to them by writing /assign @knobunc in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot
Copy link
Contributor

@rphillips: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/verify 141781b link /test verify
ci/prow/e2e-agnostic-cmd 141781b link /test e2e-agnostic-cmd
ci/prow/e2e-aws-serial 141781b link /test e2e-aws-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sttts
Copy link
Contributor

sttts commented Dec 1, 2020

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 1, 2020
@rphillips
Copy link
Contributor Author

fixed here kubernetes/kubernetes#98424

@rphillips rphillips closed this Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants