Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1902029: move off docker.io in build e2e's (approximate recent 4.7 changes) #25721

Merged

Conversation

gabemontero
Copy link
Contributor

@gabemontero gabemontero commented Nov 30, 2020

This PR picks the move to imagestream dockerimage ref's achived via #24887 in 4.7 for the build e2e's (vs. use
of busybox, centos:7, or direct ruby etc. refs to docker.io), without the additional k8s test integration and disconnected/mirroring related changes that at the moment are only in 4.7

There is mentioned of backporting some form of that entire change to 4.6.z

But this would be a more immediate subset of that, and should not conflict if that entire backport actually occurs.

/assign @adambkaplan

@openshift-ci-robot
Copy link

@gabemontero: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

More dockerio moves 46

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gabemontero gabemontero changed the title More dockerio moves 46 WIP: More dockerio moves 46 Nov 30, 2020
@openshift-ci-robot
Copy link

@gabemontero: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

WIP: More dockerio moves 46

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 30, 2020
@r4f4
Copy link
Contributor

r4f4 commented Dec 1, 2020

Nice! This PR has the added benefit of making it possible to run more e2e tests on s390x by removing the dependency on centos.

@gabemontero
Copy link
Contributor Author

https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/25721/pull-ci-openshift-origin-release-4.6-e2e-gcp-builds/1333536681587904512 has some failures I need to look at ... most likely related to the change in images ... parsing for messages in build logs and such, build name refs, etc.

@gabemontero
Copy link
Contributor Author

more cloud quota pain

/test e2e-gcp-builds

1 similar comment
@gabemontero
Copy link
Contributor Author

more cloud quota pain

/test e2e-gcp-builds

@gabemontero
Copy link
Contributor Author

OK all green e2e-gcp-builds !!

/retest

@gabemontero
Copy link
Contributor Author

/retest

3 similar comments
@gabemontero
Copy link
Contributor Author

/retest

@gabemontero
Copy link
Contributor Author

/retest

@gabemontero
Copy link
Contributor Author

/retest

@gabemontero gabemontero changed the title WIP: More dockerio moves 46 Bug 1902029: move off docker.io in build e2e's (approximate recent 4.7 changes) Dec 4, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Dec 4, 2020
@openshift-ci-robot
Copy link

@gabemontero: This pull request references Bugzilla bug 1902029, which is invalid:

  • expected dependent Bugzilla bug 1816812 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1902029: move off docker.io in build e2e's (approximate recent 4.7 changes)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Dec 4, 2020
@openshift-ci-robot
Copy link

@gabemontero: This pull request references Bugzilla bug 1902029, which is invalid:

  • expected dependent Bugzilla bug 1816812 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1902029: move off docker.io in build e2e's (approximate recent 4.7 changes)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gabemontero
Copy link
Contributor Author

/retest

4 similar comments
@gabemontero
Copy link
Contributor Author

/retest

@gabemontero
Copy link
Contributor Author

/retest

@gabemontero
Copy link
Contributor Author

/retest

@gabemontero
Copy link
Contributor Author

/retest

@gabemontero
Copy link
Contributor Author

fip flakes unrelated to build

/skip

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@gabemontero
Copy link
Contributor Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@gabemontero
Copy link
Contributor Author

/hold

the e2e-aws-upgrade failure around `LEASED_RESOURCE: unbound variable" is showing up in a lot of places according to https://search.ci.openshift.org/?search=LEASED_RESOURCE%3A+unbound+variable&maxAge=24h&context=2&type=all&name=&maxMatches=5&maxBytes=20971520&groupBy=job

I've reached out on #4-dev-triage for BZ routing guidance

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 15, 2020
@gabemontero
Copy link
Contributor Author

/hold

the e2e-aws-upgrade failure around `LEASED_RESOURCE: unbound variable" is showing up in a lot of places according to https://search.ci.openshift.org/?search=LEASED_RESOURCE%3A+unbound+variable&maxAge=24h&context=2&type=all&name=&maxMatches=5&maxBytes=20971520&groupBy=job

I've reached out on #4-dev-triage for BZ routing guidance

Looks like we need openshift/ci-tools#1535, minimally

@gabemontero
Copy link
Contributor Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 15, 2020
@gabemontero
Copy link
Contributor Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Dec 15, 2020

@gabemontero: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-csi fc4a975 link /test e2e-aws-csi
ci/prow/e2e-aws-fips fc4a975 link /test e2e-aws-fips

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gabemontero
Copy link
Contributor Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit d7fdd4e into openshift:release-4.6 Dec 15, 2020
@openshift-ci-robot
Copy link

@gabemontero: All pull requests linked via external trackers have merged:

Bugzilla bug 1902029 has been moved to the MODIFIED state.

In response to this:

Bug 1902029: move off docker.io in build e2e's (approximate recent 4.7 changes)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gabemontero gabemontero deleted the more-dockerio-moves-46 branch December 15, 2020 22:49
@abhat
Copy link
Contributor

abhat commented Jan 4, 2021

@gabemontero
Copy link
Contributor Author

gabemontero commented Jan 4, 2021

hey @abhat - yeah for 4.6 I only handled the subset of e2e for the build component that Clayton took on with his recent changes in 4.7

I have no further PRs planned.

And I don't have the bandwidth and am not taking on any throttling related updates in 4.6 for the other sig-* e2e's in the way I addressed builds, much less trying to take on backporting Clayton's entire change. I saw in the recent email from him that a 4.6.z cherrypick of his changes were being considered, and I saw an attempt in his PR to use the bot, but it hit conflicts and failed.

For example, in looking at https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/periodic-ci-openshift-release-master-ocp-4.6-e2e-vsphere/1346094150457495552 I see sig-imageregistry, sig-cli, sig-network, sig-apps but not sig-builds

IMO 4.6.z BZs should be opened against each of those sig-* components for any throttling that they are hitting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants