Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix panic dereferencing nil #25737

Merged
merged 1 commit into from Dec 4, 2020
Merged

Fix panic dereferencing nil #25737

merged 1 commit into from Dec 4, 2020

Conversation

tnozicka
Copy link
Contributor

@tnozicka tnozicka commented Dec 3, 2020 

	github.com/onsi/ginkgo@v4.5.0-origin.1+incompatible/internal/codelocation/code_location.go:19 +0x78
github.com/onsi/ginkgo.GinkgoRecover()
	github.com/onsi/ginkgo@v4.5.0-origin.1+incompatible/ginkgo_dsl.go:278 +0x66
panic(0x4fa8540, 0x8c5a1a0)
	runtime/panic.go:969 +0x175
github.com/openshift/origin/test/e2e/upgrade.(*versionMonitor).Describe(0xc001914480, 0xc00145af20)
	github.com/openshift/origin/test/e2e/upgrade/monitor.go:164 +0x702
github.com/openshift/origin/test/e2e/upgrade.clusterUpgrade(0xc00145af20, 0x647cb20, 0xc001fdcf60, 0x644f820, 0xc0020e4000, 0xc00099c480, 0x0, 0x0, 0x0, 0x0, ...)
	github.com/openshift/origin/test/e2e/upgrade/upgrade.go:330 +0x76c
github.com/openshift/origin/test/e2e/upgrade.glob..func1.1.1()

https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/25731/pull-ci-openshift-origin-master-e2e-gcp-upgrade/1334452788603654144#1:build-log.txt%3A573

/cc @soltysh

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2020
soltysh
soltysh approved these changes Dec 3, 2020
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: soltysh, tnozicka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tnozicka tnozicka mentioned this pull request Dec 3, 2020
Merged
@tnozicka
Copy link
Contributor Author

tnozicka commented Dec 3, 2020

aws vpc limit
/retest

@tnozicka
Copy link
Contributor Author

tnozicka commented Dec 3, 2020

/retest

1 similar comment
@tnozicka
Copy link
Contributor Author

tnozicka commented Dec 4, 2020

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 831e9a2 into openshift:master Dec 4, 2020
@tnozicka tnozicka deleted the fix-panic branch December 4, 2020 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

Assignees

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tnozicka @openshift-ci-robot @openshift-bot @soltysh @openshift-merge-robot