Bug 1900989: test/cmd/idle: don't delete the service during the test

[frobware]

oc/idle will now additionally annotate the service. The test
explicitly deletes it so removing that call so that we can verify the
following PRs, all related to annotating the service when idling.

• Bug 1900989: idle: also annotate the service oc#720
• Bug 1900989: Move idle check from endpoints to service router#225
• Bug 1900989: Unidling use Services annotations, switch away from Endpoints sdn#252
• Bug 1900989: policy/unidling-controller: allow get/update on services openshift-apiserver#180
• Bug 1900989: unidling: switch away from endpoints to the service openshift-controller-manager#165

[openshift-ci-robot]

@frobware: This pull request references Bugzilla bug 1900989, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.7.0) matches configured target release for branch (4.7.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1900989: test/cmd/idle: don't delete the service during the test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[frobware]

/hold

I don't know whether deleting the service will break the test but I need this and the following PRs for testing the change:

• Bug 1900989: idle: also annotate the service oc#720
• Bug 1900989: Move idle check from endpoints to service router#225
• Bug 1900989: Unidling use Services annotations, switch away from Endpoints sdn#252
• Bug 1900989: policy/unidling-controller: allow get/update on services openshift-apiserver#180
• Bug 1900989: unidling: switch away from endpoints to the service openshift-controller-manager#165

[frobware]

We see the test failure in the corresponding oc/idle change openshift/oc#720 (comment).

[sgreene570]

might need a make generate

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: frobware
To complete the pull request process, please assign knobunc after the PR has been reviewed.
You can assign the PR to them by writing /assign @knobunc in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• test/extended/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[frobware]

might need a make generate

Thanks - Done in 3084881

[openshift-ci]

@frobware: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/verify	3084881	link	/test verify

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[frobware]

@sgreene570 going to close this as you've already identified we need to change the how the test works.

[openshift-ci-robot]

@frobware: This pull request references Bugzilla bug 1900989. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to this:

Bug 1900989: test/cmd/idle: don't delete the service during the test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sgreene570]

superseded by #25844