Bug 1922991: allow OKD /run contents for build fs test #25845
Conversation
openshift-ci-robot
added
the
approved
|
/retitle Bug 1922991: allow OKD /run contents for build fs test |
|
/retest |
openshift-ci-robot
changed the title
|
@gabemontero: This pull request references Bugzilla bug 1922991, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/severity-high
|
/retest |
1 similar comment
|
/retest |
|
fwiw so far the e2e failures have been of the cloud / cluster setup variety and the new test in question has not run |
|
openshift/release#11925 would add OKD tests, but it seems to be stuck on testplatform issues. The fix looks good enough for me, thanks! |
|
/retest |
|
Looks like a real error: |
oooh .. thanks I'll take a look |
gabemontero
force-pushed
the
fix-fs-okd-47
branch
from
9d7c9e7
to
b838c86
Compare
|
ok that yaml worked for me locally ... let's see how CI does |
|
/skip |
|
gpc, gcp-builds, aws-fips all green @adambkaplan @vrutkovs please review / lgtm at your discretion |
|
aws-serial failures were in sig-scheduling and sig-networking /test e2e-aws-serial |
|
LGTM |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan, gabemontero The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
2 sig-scheduling failures with aws-serial /test e2e-aws-serial |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@gabemontero: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@gabemontero: All pull requests linked via external trackers have merged: Bugzilla bug 1922991 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick release-4.6 |
|
@gabemontero: new pull request created: #25851 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
This seems to work in OKD now - https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/release-openshift-okd-installer-e2e-aws-4.7/1356956655350190080 doesn't have this test failing. Thanks! |
@wewang58 yeah per our discussion in the bz let's mark verified since BZ was OKD specific ^^ |
addresses
https://storage.googleapis.com/origin-ci-test/logs/release-openshift-okd-installer-e2e-aws-4.7/1355560957442527232/build-log.txt
@vrutkovs
can you open a BZ to facilitate this FIX?
and is there any pre-merge OKD validation we can/should do?
/assign @adambkaplan
@adambkaplan - I believe I also addressed some nit but merge anyway comments in this new file that you had ...
dockerfile: |-for better readability