Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1957295: test/extended/pods/priorityclasses: Improve error actionability #26174

Merged
merged 1 commit into from May 21, 2021
Merged

Bug 1957295: test/extended/pods/priorityclasses: Improve error actionability #26174

merged 1 commit into from May 21, 2021

Conversation

wking
Copy link
Member

@wking wking commented May 20, 2021

Instead of just telling folks which pods are broken, tell folks what the current config is and what the expected config is, so they don't have to dig around to figure out how to fix their component.

Following up on d6c4a51 (#25931), CC @ravisantoshgudimetla.

ravisantoshgudimetla
ravisantoshgudimetla approved these changes May 20, 2021
View reviewed changes
Copy link
Contributor

@ravisantoshgudimetla ravisantoshgudimetla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this @wking

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2021
@wking wking force-pushed the invalid-tolerations-reasons branch from 566baa6 to f059372 Compare May 20, 2021 17:12
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 20, 2021
@wking wking force-pushed the invalid-tolerations-reasons branch from f059372 to e5d8801 Compare May 20, 2021 17:17
@wking
test/extended/pods/priorityclasses: Improve error actionability
368a632 
Instead of just telling folks which pods are broken, tell folks what
the current config is and what the expected config is, so they don't
have to dig around to figure out how to fix their component.

Also switch from Contains to HasPrefix, because as pointed out in
d6c4a51 (Components should have required Priorityclass, 2021-05-02, openshift#25931),
we're looking for openshift-user-critical, system-cluster-critical, or
system-node-critical.
@wking wking force-pushed the invalid-tolerations-reasons branch from e5d8801 to 368a632 Compare May 20, 2021 17:50
@wking wking changed the title test/extended/pods/priorityclasses: Improve error actionability Bug 1957295: test/extended/pods/priorityclasses: Improve error actionability May 20, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 20, 2021

@wking: This pull request references Bugzilla bug 1957295, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @kasturinarra

In response to this:

Bug 1957295: test/extended/pods/priorityclasses: Improve error actionability

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels May 20, 2021
@openshift-ci openshift-ci bot requested a review from kasturinarra May 20, 2021 18:47
@wking
Copy link
Member Author

wking commented May 20, 2021

@soltysh, you approved the earlier PR; can you review this follow-up?

soltysh
soltysh approved these changes May 21, 2021
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 21, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ravisantoshgudimetla, soltysh, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 21, 2021 •
edited

@wking: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-gcp-disruptive 368a632 link /test e2e-gcp-disruptive
ci/prow/e2e-aws-csi 368a632 link /test e2e-aws-csi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 8b440b3 into openshift:master May 21, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 21, 2021

@wking: All pull requests linked via external trackers have merged:

Bugzilla bug 1957295 has been moved to the MODIFIED state.

In response to this:

Bug 1957295: test/extended/pods/priorityclasses: Improve error actionability

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking wking deleted the invalid-tolerations-reasons branch May 22, 2021 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@ravisantoshgudimetla ravisantoshgudimetla ravisantoshgudimetla approved these changes

@ironcladlou ironcladlou Awaiting requested review from ironcladlou

@knobunc knobunc Awaiting requested review from knobunc

@kasturinarra kasturinarra Awaiting requested review from kasturinarra

Assignees

@soltysh soltysh

@ravisantoshgudimetla ravisantoshgudimetla

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@wking @openshift-bot @soltysh @ravisantoshgudimetla @openshift-merge-robot