Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUILD-278: account for cgroup v2 swap file only having swap for its amount, while cgroup v1 has memory+swap for its amount #26399

Conversation

gabemontero
Copy link
Contributor

For those at RH, see https://coreos.slack.com/archives/C02258G4S79/p1629139934121300 for the tl;dr between @nalind and myself

summary: the cgroup swap files mean different things (memory+swap in v1, just swap in v2) our our build quota tests needs to account for this

/assign @adambkaplan
or
/assign @coreydaley

whoever has the more immediate cycles. Feel free to unassign as needed.

shellcheck:

gmontero ~/go/src/github.com/openshift/origin  (possible-cgroupv2-shell-solution-2)$ shellcheck test/extended/testdata/builds/build-quota/.s2i/bin/assemble 
gmontero ~/go/src/github.com/openshift/origin  (possible-cgroupv2-shell-solution-2)$ 

/assign @bparees
if you are still amenable to adding valid bz label so I can then test against this in openshift/builder#252

fingers crossed last iteration on this

@bparees bparees added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 16, 2021
@coreydaley
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 16, 2021
@gabemontero
Copy link
Contributor Author

/test e2e-gcp
/test e2e-aws-fips

@gabemontero
Copy link
Contributor Author

/lgtm

thanks @coreydaley

e2e-gcp-builds passed, so we are just battling flakes @adambkaplan re: approval, depending on when you circle to this during post PTO catch up - thanks

@gabemontero
Copy link
Contributor Author

thanks @bparees re valid bz label

@gabemontero
Copy link
Contributor Author

/retest

@gabemontero
Copy link
Contributor Author

/skip

@gabemontero
Copy link
Contributor Author

/refresh

@gabemontero
Copy link
Contributor Author

/test e2e-gcp

@gabemontero
Copy link
Contributor Author

another intermittent flake cited in sippy with a bz ... posted the failling job info in bz

/test e2e-gcp

Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 17, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, coreydaley, gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 17, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@gabemontero
Copy link
Contributor Author

/retest

@gabemontero
Copy link
Contributor Author

/test e2e-metal-ipi-ovn-ipv6

@gabemontero
Copy link
Contributor Author

/refresh

@openshift-ci-robot
Copy link

@gabemontero: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-agnostic-cmd a175b05 link /test e2e-agnostic-cmd
ci/prow/e2e-aws-single-node a175b05 link /test e2e-aws-single-node
ci/prow/e2e-metal-ipi-ovn-ipv6 a175b05 link /test e2e-metal-ipi-ovn-ipv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gabemontero
Copy link
Contributor Author

/retest

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@gabemontero
Copy link
Contributor Author

/test e2e-gcp-upgrade

@gabemontero
Copy link
Contributor Author

/retest

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@gabemontero
Copy link
Contributor Author

/retest

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 19, 2021

@gabemontero: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-agnostic-cmd a175b05 link /test e2e-agnostic-cmd
ci/prow/e2e-aws-single-node a175b05 link /test e2e-aws-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit b58ad6c into openshift:master Aug 19, 2021
@gabemontero gabemontero deleted the possible-cgroupv2-shell-solution-2 branch August 19, 2021 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants