Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oauth e2e: fix the expected http2 error to match golang 1.17+ #26594

Merged
merged 1 commit into from Nov 11, 2021

Conversation

stlaz
Copy link
Member

@stlaz stlaz commented Nov 11, 2021

Golang 1.17 made it so that a TLS connection is terminated when
a client with supported ALPN protocols attempts to reach a server
that does not support any ALPN protocols or the clients' ALPN
protocols don't match those of the server.

Golang 1.17 made it so that a TLS connection is terminated when
a client with supported ALPN protocols attempts to reach a server
that does not support any ALPN protocols or the clients' ALPN
protocols don't match those of the server.
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 11, 2021
@deads2k
Copy link
Contributor

deads2k commented Nov 11, 2021

/lgtm

I want my payload! :)

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 11, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, stlaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 11, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 11, 2021

@stlaz: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-cgroupsv2 f062561 link false /test e2e-aws-cgroupsv2
ci/prow/e2e-agnostic-cmd f062561 link false /test e2e-agnostic-cmd
ci/prow/e2e-gcp-csi f062561 link false /test e2e-gcp-csi
ci/prow/e2e-gcp f062561 link true /test e2e-gcp
ci/prow/e2e-gcp-upgrade f062561 link true /test e2e-gcp-upgrade
ci/prow/e2e-aws-single-node f062561 link false /test e2e-aws-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@deads2k
Copy link
Contributor

deads2k commented Nov 11, 2021

GCP tests are blocked on another problem, I'm going to take a chance on this.

@deads2k deads2k merged commit 2aa3ec9 into openshift:master Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants