Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1919453: [release-4.6] configure tests to pull images from mirror #26729

Conversation

rvanderp3
Copy link
Contributor

@rvanderp3 rvanderp3 commented Jan 5, 2022

The intention of this PR is to enable some tests in the openshift/conformance/parallel suite which are not subject to the mirror configuration in /etc/containers/registries.conf to use a mirror as the source of their required images.

Note: The pattern in this PR could be applied to other suites as well.

This is needed due to docker.io rate limiting causing CI on some platforms on 4.6 to be in permafail. To use the feature in this PR:

  • Prior to running openshift-tests, export TEST_IMAGE_MIRROR_REGISTRY=<pull-through-cache-host>:<port>
  • Configure a pull-through cache for docker.io with a certificate signed by a well-known CA on a bastion that is only reachable by the nodes executing e2e tests. For example:
podman run -d -p 5000:5000 -v /home/admin/registry_storage:/var/lib/registry:Z -v /home/admin/registry_certs:/certs:Z --restart always --name registry-docker.io -e REGISTRY_HTTP_ADDR=0.0.0.0:5000 -e REGISTRY_HTTP_TLS_CERTIFICATE=/certs/domain.crt -e REGISTRY_HTTP_TLS_KEY=/certs/domain.key -e REGISTRY_PROXY_REMOTEURL="https://registry-1.docker.io" -e REGISTRY_PROXY_USERNAME=<optional user name> -e REGISTRY_PROXY_PASSWORD=<optional password> registry:2

To enable resources which can take advantage of the mirror registry, apply a machine-config which configures the pull-through cache as a docker.io registry mirror. This will allow, over the course of a day or so(based on pull-rate exhaustion), for all required images to be pulled and cached.

This PR is an alternate to solution to that proposed in #26256

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 5, 2022

@rvanderp3: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[wip] configure tests to pull images from mirror

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 5, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 5, 2022
@rvanderp3 rvanderp3 force-pushed the patch-docker-io-references branch 2 times, most recently from 6be318d to 66e920a Compare January 5, 2022 22:28
@rvanderp3 rvanderp3 changed the title [wip] configure tests to pull images from mirror [release-4.6] configure tests to pull images from mirror Jan 6, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 6, 2022

@rvanderp3: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.6] configure tests to pull images from mirror

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rvanderp3 rvanderp3 marked this pull request as ready for review January 6, 2022 14:05
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 6, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 6, 2022

@rvanderp3: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.6] configure tests to pull images from mirror

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 6, 2022

@rvanderp3: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[wip] configure tests to pull images from mirror

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 6, 2022
@rvanderp3 rvanderp3 changed the title [release-4.6] configure tests to pull images from mirror [release-4.6] Bug 1919453: configure tests to pull images from mirror Jan 6, 2022
@rvanderp3 rvanderp3 changed the title [release-4.6] Bug 1919453: configure tests to pull images from mirror Bug 1919453: [release-4.6] configure tests to pull images from mirror Jan 6, 2022
@rvanderp3
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 6, 2022

@rvanderp3: An error was encountered querying GitHub for users with public email (bandrade@redhat.com) for bug 1919453 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. Post "http://ghproxy/graphql": dial tcp 172.30.229.2:80: i/o timeout

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

[release-4.6] Bug 1919453: configure tests to pull images from mirror

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jan 6, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 6, 2022

@rvanderp3: This pull request references Bugzilla bug 1919453, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.z) matches configured target release for branch (4.6.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1816812 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1816812 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0, 4.7.z
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (bandrade@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 6, 2022
@rvanderp3
Copy link
Contributor Author

/cc @bparees

@openshift-ci openshift-ci bot requested a review from bparees January 6, 2022 14:16
@bparees bparees added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Jan 6, 2022
@bparees
Copy link
Contributor

bparees commented Jan 6, 2022

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2022
@rvanderp3
Copy link
Contributor Author

/hold

A possible regression in e2e-aws/e2e-gcp needs to be addressed. Will remove hold once done.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 6, 2022
@rvanderp3 rvanderp3 force-pushed the patch-docker-io-references branch 2 times, most recently from bcb26ad to 11eaaa1 Compare January 6, 2022 17:30
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 6, 2022

@rvanderp3: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agnostic-cmd 379aa4e link false /test e2e-agnostic-cmd

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jcpowermac
Copy link

/lgtm

@rvanderp3
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 6, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 6, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, jcpowermac, rvanderp3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 1a58eae into openshift:release-4.6 Jan 6, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 6, 2022

@rvanderp3: All pull requests linked via external trackers have merged:

Bugzilla bug 1919453 has been moved to the MODIFIED state.

In response to this:

Bug 1919453: [release-4.6] configure tests to pull images from mirror

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants