Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2052058: Break out test for OSUpdateStaged event with no OSUpdateStarted #26830

Merged
merged 1 commit into from Feb 10, 2022
Merged

Bug 2052058: Break out test for OSUpdateStaged event with no OSUpdateStarted #26830

merged 1 commit into from Feb 10, 2022

Conversation

dgoodwin
Copy link
Contributor

@dgoodwin dgoodwin commented Feb 9, 2022 •
edited

  • Break out test for OSUpdateStaged event with no OSUpdateStarted.

Cherry pick from #26824

@dgoodwin
Break out test for OSUpdateStaged event with no OSUpdateStarted.
99badbf 
This is confirmed to be happening and we can see that we're missing
events in the disruption monitor watch when apiservers are upgrading.

Move this scenario out to it's own test, which will only ever flake,
while we work on a fix.

Original test will now ignore this scenario.
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 9, 2022
@dgoodwin dgoodwin changed the base branch from master to release-4.10 February 9, 2022 11:59
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 9, 2022

@dgoodwin: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

osupdate missing event flake 410

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 9, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 9, 2022

@dgoodwin: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

osupdate missing event flake 410

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dgoodwin dgoodwin changed the title osupdate missing event flake 410 Bug 2052058: Break out test for OSUpdateStaged event with no OSUpdateStarted Feb 9, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 9, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 9, 2022

@dgoodwin: This pull request references Bugzilla bug 2052058, which is invalid:

  • expected Bugzilla bug 2052058 to depend on a bug targeting a release in 4.11.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2052058: Break out test for OSUpdateStaged event with no OSUpdateStarted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dgoodwin
Copy link
Contributor Author

dgoodwin commented Feb 9, 2022

/bugzilla refresh

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 9, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 9, 2022

@dgoodwin: This pull request references Bugzilla bug 2052058, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2052497 is in the state VERIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Bugzilla bug 2052497 targets the "4.11.0" release, which is one of the valid target releases: 4.11.0
  • bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 9, 2022
@deads2k
Copy link
Contributor

deads2k commented Feb 9, 2022

/lgtm
/approve

@deads2k deads2k added staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. labels Feb 9, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 9, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 9, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, dgoodwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 9, 2022
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 10, 2022

@dgoodwin: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agnostic-cmd 99badbf link false /test e2e-agnostic-cmd
ci/prow/e2e-gcp-builds 99badbf link true /test e2e-gcp-builds
ci/prow/e2e-aws-fips 99badbf link true /test e2e-aws-fips
ci/prow/e2e-aws-cgroupsv2 99badbf link false /test e2e-aws-cgroupsv2
ci/prow/e2e-aws-serial 99badbf link true /test e2e-aws-serial
ci/prow/e2e-gcp-upgrade 99badbf link true /test e2e-gcp-upgrade
ci/prow/e2e-aws-single-node 99badbf link false /test e2e-aws-single-node
ci/prow/e2e-metal-ipi-ovn-ipv6 99badbf link false /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-aws-csi 99badbf link false /test e2e-aws-csi
ci/prow/okd-e2e-gcp 99badbf link false /test okd-e2e-gcp
ci/prow/e2e-gcp 99badbf link true /test e2e-gcp
ci/prow/verify-deps 99badbf link true /test verify-deps
ci/prow/verify 99badbf link true /test verify
ci/prow/e2e-gcp-fips-serial 99badbf link false /test e2e-gcp-fips-serial
ci/prow/e2e-gcp-csi 99badbf link false /test e2e-gcp-csi
ci/prow/e2e-aws-single-node 99badbf link false /test e2e-aws-single-node
ci/prow/images 99badbf link true /test images
ci/prow/e2e-aws-csi 99badbf link false /test e2e-aws-csi
ci/prow/e2e-agnostic-cmd 99badbf link false /test e2e-agnostic-cmd

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit a638d29 into openshift:release-4.10 Feb 10, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 10, 2022

@dgoodwin: All pull requests linked via external trackers have merged:

Bugzilla bug 2052058 has been moved to the MODIFIED state.

In response to this:

Bug 2052058: Break out test for OSUpdateStaged event with no OSUpdateStarted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwforres jwforres Awaiting requested review from jwforres

@mfojtik mfojtik Awaiting requested review from mfojtik

Assignees

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dgoodwin @deads2k @openshift-bot @openshift-merge-robot