New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2085997: brings back the etcd scaling test #27176
Bug 2085997: brings back the etcd scaling test #27176
Conversation
This reverts commit 6274fe6.
…for a machine the providerID is an optional field, on some platforms (i.e. Libvirt), it is empty. In that cases, this PR proposes to find a corresponding node by an internal IP of a machine.
The etcd client factory used by the method establishes a stream connection to an etcd pod. Since a connection like this is considered a long-running connection and isn't subjected to gracefully termination and the fact it runs after deleting a machine gives a reason to tolerate some failures while getting a list of members. Note that unavailability of the APIs and the etcd cluster will be reported by the monitor tool.
…for api servers to stabilize on the same revision
/assign @soltysh |
/hold until required PRs get merged. |
/payload 4.11 nightly informing |
@p0lyn0mial: trigger 48 jobs of type informing for the nightly release of OCP 4.11
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a1675010-dcd5-11ec-98d0-180d56e8aec8-0 |
@p0lyn0mial: This pull request references Bugzilla bug 2085997, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@p0lyn0mial: This pull request references Bugzilla bug 2085997, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
2 similar comments
@p0lyn0mial: This pull request references Bugzilla bug 2085997, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@p0lyn0mial: This pull request references Bugzilla bug 2085997, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: p0lyn0mial, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/hold openshift/cluster-etcd-operator#838 is being reverted and a new mechanism needs to be tried. Detailed in that PR. |
@p0lyn0mial: This pull request references Bugzilla bug 2085997, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest-required |
/hold cancel |
/retest-required |
/hold |
/test e2e-aws-serial |
it looks like it keeps failing on |
/test e2e-aws-serial |
3 similar comments
/test e2e-aws-serial |
/test e2e-aws-serial |
/test e2e-aws-serial |
@p0lyn0mial: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/test e2e-aws-serial |
1 similar comment
/test e2e-aws-serial |
/hold cancel |
@p0lyn0mial: Some pull requests linked via external trackers have merged:
The following pull requests linked via external trackers have not merged:
These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with Bugzilla bug 2085997 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
this PR:
EnsureMemberRemoved
to tolerate some failures (Bug 2085997: EnsureMemberRemoved tolerates some failures #27163)EnsureVotingMembersCount
to check theetcd-endpoints
cmrequires openshift/cluster-etcd-operator#840 and openshift/etcd#131
unfortunately, i cannot test aginst
libvirt
, not even from theclusterbot