Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2085997: brings back the etcd scaling test #27176

Merged

Conversation

p0lyn0mial
Copy link
Contributor

@p0lyn0mial p0lyn0mial commented May 26, 2022

this PR:

requires openshift/cluster-etcd-operator#840 and openshift/etcd#131

unfortunately, i cannot test aginst libvirt, not even from the clusterbot

test e2e-serial-remote-libvirt-ppc64le openshift/origin#27176

warning: You are using a custom test name, may not be supported for all platforms: e2e, e2e-serial, e2e-all, e2e-disruptive, e2e-disruptive-all, e2e-builds, e2e-image-ecosystem, e2e-image-registry, e2e-network-stress
the requested job cannot be started: unknown test type e2e-serial-remote-libvirt-ppc64le

…for a machine

the providerID is an optional field, on some platforms (i.e. Libvirt), it is empty.
In that cases, this PR proposes to find a corresponding node by an internal IP of a machine.
The etcd client factory used by the method establishes a stream connection to an etcd pod.
Since a connection like this is considered a long-running connection
and isn't subjected to gracefully termination
and the fact it runs after deleting a machine gives a reason to tolerate some failures while getting a list of members.

Note that unavailability of the APIs and the etcd cluster will be reported by the monitor tool.
…for api servers to stabilize on the same revision
@p0lyn0mial
Copy link
Contributor Author

/assign @soltysh

@p0lyn0mial
Copy link
Contributor Author

/hold

until required PRs get merged.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 26, 2022
@openshift-ci openshift-ci bot added the vendor-update Touching vendor dir or related files label May 26, 2022
@p0lyn0mial
Copy link
Contributor Author

/payload 4.11 nightly informing

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 26, 2022

@p0lyn0mial: trigger 48 jobs of type informing for the nightly release of OCP 4.11

  • periodic-ci-openshift-release-master-nightly-4.11-e2e-alibaba
  • periodic-ci-openshift-release-master-nightly-4.11-e2e-aws
  • periodic-ci-openshift-release-master-nightly-4.11-console-aws
  • periodic-ci-openshift-release-master-nightly-4.11-e2e-aws-csi
  • periodic-ci-openshift-release-master-nightly-4.11-e2e-aws-fips
  • periodic-ci-openshift-release-master-ci-4.11-e2e-aws-ovn
  • periodic-ci-openshift-release-master-nightly-4.11-e2e-aws-single-node
  • periodic-ci-openshift-release-master-nightly-4.11-e2e-aws-single-node-serial
  • periodic-ci-openshift-release-master-ci-4.11-e2e-aws-techpreview
  • periodic-ci-openshift-release-master-ci-4.11-e2e-aws-techpreview-serial
  • periodic-ci-openshift-release-master-nightly-4.11-e2e-azure
  • periodic-ci-openshift-release-master-nightly-4.11-e2e-azure-csi
  • periodic-ci-openshift-release-master-ci-4.11-e2e-azure-ovn
  • periodic-ci-openshift-release-master-ci-4.11-e2e-azure-techpreview
  • periodic-ci-openshift-release-master-ci-4.11-e2e-azure-techpreview-serial
  • periodic-ci-openshift-release-master-ci-4.11-e2e-azure-upgrade-single-node
  • periodic-ci-openshift-release-master-nightly-4.11-e2e-azure-deploy-cnv
  • periodic-ci-openshift-release-master-nightly-4.11-e2e-azure-upgrade-cnv
  • periodic-ci-openshift-release-master-nightly-4.11-e2e-aws-driver-toolkit
  • periodic-ci-openshift-release-master-nightly-4.11-e2e-gcp
  • periodic-ci-openshift-release-master-nightly-4.11-e2e-gcp-csi
  • periodic-ci-openshift-release-master-ci-4.11-e2e-gcp-ovn
  • periodic-ci-openshift-release-master-nightly-4.11-e2e-gcp-rt
  • periodic-ci-openshift-release-master-ci-4.11-e2e-gcp-techpreview
  • periodic-ci-openshift-release-master-ci-4.11-e2e-gcp-techpreview-serial
  • periodic-ci-openshift-release-master-nightly-4.11-e2e-metal-assisted
  • periodic-ci-openshift-release-master-nightly-4.11-e2e-metal-ipi-ovn-dualstack
  • periodic-ci-openshift-release-master-nightly-4.11-e2e-metal-ipi-serial-ovn-ipv6
  • periodic-ci-openshift-release-master-nightly-4.11-e2e-metal-ipi-serial-ovn-dualstack
  • periodic-ci-openshift-release-master-nightly-4.11-e2e-metal-ipi-serial-virtualmedia
  • periodic-ci-openshift-release-master-nightly-4.11-e2e-metal-ipi-upgrade
  • periodic-ci-openshift-release-master-nightly-4.11-upgrade-from-stable-4.10-e2e-metal-ipi-upgrade
  • periodic-ci-openshift-release-master-nightly-4.11-e2e-metal-ipi-upgrade-ovn-ipv6
  • periodic-ci-openshift-release-master-nightly-4.11-upgrade-from-stable-4.10-e2e-metal-ipi-upgrade-ovn-ipv6
  • periodic-ci-openshift-release-master-nightly-4.11-e2e-metal-ipi-virtualmedia
  • periodic-ci-openshift-release-master-nightly-4.11-e2e-ovirt
  • periodic-ci-openshift-release-master-nightly-4.11-e2e-ovirt-csi
  • periodic-ci-openshift-release-master-nightly-4.11-e2e-aws-proxy
  • periodic-ci-openshift-release-master-nightly-4.11-e2e-metal-single-node-live-iso
  • periodic-ci-openshift-release-master-nightly-4.11-e2e-aws-upgrade
  • periodic-ci-openshift-release-master-nightly-4.11-upgrade-from-stable-4.10-e2e-aws-upgrade
  • periodic-ci-openshift-release-master-nightly-4.11-e2e-vsphere
  • periodic-ci-openshift-release-master-nightly-4.11-e2e-vsphere-csi
  • periodic-ci-openshift-release-master-nightly-4.11-e2e-vsphere-serial
  • periodic-ci-openshift-release-master-nightly-4.11-e2e-vsphere-techpreview
  • periodic-ci-openshift-release-master-nightly-4.11-e2e-vsphere-techpreview-serial
  • periodic-ci-openshift-release-master-nightly-4.11-e2e-vsphere-upi
  • periodic-ci-openshift-release-master-nightly-4.11-e2e-vsphere-upi-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a1675010-dcd5-11ec-98d0-180d56e8aec8-0

@p0lyn0mial p0lyn0mial changed the title brings back the etcd scaling test Bug 2085997: brings back the etcd scaling test May 26, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels May 26, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 26, 2022

@p0lyn0mial: This pull request references Bugzilla bug 2085997, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @geliu2016

In response to this:

Bug 2085997: brings back the etcd scaling test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from geliu2016 May 26, 2022 09:24
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 26, 2022

@p0lyn0mial: This pull request references Bugzilla bug 2085997, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @geliu2016

In response to this:

Bug 2085997: brings back the etcd scaling test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

2 similar comments
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 26, 2022

@p0lyn0mial: This pull request references Bugzilla bug 2085997, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @geliu2016

In response to this:

Bug 2085997: brings back the etcd scaling test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 26, 2022

@p0lyn0mial: This pull request references Bugzilla bug 2085997, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @geliu2016

In response to this:

Bug 2085997: brings back the etcd scaling test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 26, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 26, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: p0lyn0mial, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2022
@p0lyn0mial
Copy link
Contributor Author

/hold cancel
/retest-required

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 26, 2022
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@deads2k
Copy link
Contributor

deads2k commented May 26, 2022

/hold

openshift/cluster-etcd-operator#838 is being reverted and a new mechanism needs to be tried. Detailed in that PR.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 26, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 26, 2022

@p0lyn0mial: This pull request references Bugzilla bug 2085997, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @geliu2016

In response to this:

Bug 2085997: brings back the etcd scaling test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@p0lyn0mial
Copy link
Contributor Author

/retest-required

@p0lyn0mial
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 30, 2022
@p0lyn0mial
Copy link
Contributor Author

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 2 against base HEAD f0eef9f and 8 for PR HEAD f561264 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 1 against base HEAD f0eef9f and 7 for PR HEAD f561264 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD f0eef9f and 6 for PR HEAD f561264 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 2 against base HEAD d7877e3 and 5 for PR HEAD f561264 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 1 against base HEAD d7877e3 and 4 for PR HEAD f561264 in total

@p0lyn0mial
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 31, 2022
@p0lyn0mial
Copy link
Contributor Author

/test e2e-aws-serial

@p0lyn0mial
Copy link
Contributor Author

it looks like it keeps failing on No CNI configuration file in /etc/kubernetes/cni/net.d/. Has your network provider started?

@p0lyn0mial
Copy link
Contributor Author

/test e2e-aws-serial

3 similar comments
@p0lyn0mial
Copy link
Contributor Author

/test e2e-aws-serial

@p0lyn0mial
Copy link
Contributor Author

/test e2e-aws-serial

@p0lyn0mial
Copy link
Contributor Author

/test e2e-aws-serial

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 1, 2022

@p0lyn0mial: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agnostic-cmd f561264 link false /test e2e-agnostic-cmd
ci/prow/e2e-gcp-ovn-rt-upgrade f561264 link false /test e2e-gcp-ovn-rt-upgrade
ci/prow/e2e-aws-single-node-upgrade f561264 link false /test e2e-aws-single-node-upgrade
ci/prow/e2e-aws-csi f561264 link false /test e2e-aws-csi
ci/prow/e2e-aws-single-node f561264 link false /test e2e-aws-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@p0lyn0mial
Copy link
Contributor Author

/test e2e-aws-serial

1 similar comment
@p0lyn0mial
Copy link
Contributor Author

/test e2e-aws-serial

@p0lyn0mial
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 2, 2022
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 2 against base HEAD b8672b8 and 3 for PR HEAD f561264 in total

@openshift-merge-robot openshift-merge-robot merged commit 74acdf4 into openshift:master Jun 2, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 2, 2022

@p0lyn0mial: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 2085997 has not been moved to the MODIFIED state.

In response to this:

Bug 2085997: brings back the etcd scaling test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants