Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2086086: update samples for 4.11 #27234

Merged
merged 2 commits into from Jun 10, 2022
Merged

Bug 2086086: update samples for 4.11 #27234

merged 2 commits into from Jun 10, 2022

Conversation

yselkowitz
Copy link
Contributor

The image_ecosystem additions depend on openshift/cluster-samples-operator#428

/cc @fbm3307

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 8, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 8, 2022

@yselkowitz: GitHub didn't allow me to request PR reviews from the following users: fbm3307.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

The image_ecosystem additions depend on openshift/cluster-samples-operator#428

/cc @fbm3307

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 8, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jun 8, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 8, 2022

@yselkowitz: This pull request references Bugzilla bug 2086086, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @tisutisu

In response to this:

Bug 2086086: update samples for 4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from tisutisu June 8, 2022 15:00
@openshift-ci openshift-ci bot mentioned this pull request Jun 8, 2022
Merged
@yselkowitz
Copy link
Contributor Author

yselkowitz commented Jun 8, 2022 •
edited

Waiting for the next CI snapshot, in the meantime
/cc @adambkaplan @coreydaley @dperaza4dustbit @fbm3307 @gabemontero

@yselkowitz yselkowitz marked this pull request as ready for review June 8, 2022 20:00
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 8, 2022
@yselkowitz yselkowitz changed the title Bug 2086086: update samples for 4.11 Bug 2086086: update middleware samples for 4.11 Jun 8, 2022
@yselkowitz yselkowitz changed the title Bug 2086086: update middleware samples for 4.11 Bug 2086086: update samples for 4.11 Jun 8, 2022
@yselkowitz
Copy link
Contributor Author

/retest

1 similar comment
@yselkowitz
Copy link
Contributor Author

/retest

@yselkowitz
Copy link
Contributor Author

/test e2e-agnostic-cmd

@openshift-ci openshift-ci bot mentioned this pull request Jun 9, 2022
Merged
@yselkowitz
Copy link
Contributor Author

/test e2e-agnostic-cmd

@yselkowitz
Copy link
Contributor Author

/assign @bparees

@bparees bparees mentioned this pull request Jun 10, 2022
Merged
@bparees
Copy link
Contributor

bparees commented Jun 10, 2022

/approve

@bparees
Copy link
Contributor

bparees commented Jun 10, 2022

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 10, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, yselkowitz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Jun 10, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 10, 2022

@yselkowitz: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-single-node-upgrade 52ab382 link false /test e2e-aws-single-node-upgrade
ci/prow/e2e-metal-ipi-ovn-ipv6 52ab382 link false /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-agnostic-cmd 52ab382 link false /test e2e-agnostic-cmd

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 517a5cf into openshift:master Jun 10, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 10, 2022

@yselkowitz: All pull requests linked via external trackers have merged:

Bugzilla bug 2086086 has been moved to the MODIFIED state.

In response to this:

Bug 2086086: update samples for 4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yselkowitz yselkowitz deleted the imagestreams branch June 13, 2022 23:22
@openshift-ci openshift-ci bot mentioned this pull request Jun 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tisutisu tisutisu Awaiting requested review from tisutisu

@adambkaplan adambkaplan Awaiting requested review from adambkaplan

@coreydaley coreydaley Awaiting requested review from coreydaley

@dperaza4dustbit dperaza4dustbit Awaiting requested review from dperaza4dustbit

@gabemontero gabemontero Awaiting requested review from gabemontero

Assignees

@bparees bparees

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yselkowitz @bparees @openshift-merge-robot