Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.11] Bug 2106942: use multi-arch ldap and multicast test images #27305

Merged
merged 2 commits into from Aug 10, 2022
Merged

[release-4.11] Bug 2106942: use multi-arch ldap and multicast test images #27305

merged 2 commits into from Aug 10, 2022

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #27169

/assign yselkowitz

@yselkowitz
Use multi-arch ldap and multicast test images
19612f3
@yselkowitz
ldap: fix listener URL syntax for newer openldap
08a004a 
With a newer ldap test image, the LDAP tests fail with an error:

daemon: listener URL ldap://(null)/<junk> DN must be absent

This syntax is checked as of 2.4.56 (Fedora 34 has 2.4.57):

https://bugs.openldap.org/show_bug.cgi?id=9379
https://git.openldap.org/openldap/openldap/-/commit/db46f888530aeae83e0c1d853083c62b8e855987
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 13, 2022
Merged
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 13, 2022

@openshift-cherrypick-robot: Bugzilla bug 2089966 has been cloned as Bugzilla bug 2106942. Retitling PR to link against new bug.
/retitle [release-4.11] Bug 2106942: use multi-arch ldap and multicast test images

In response to this:

[release-4.11] Bug 2089966: use multi-arch ldap and multicast test images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.11] Bug 2089966: use multi-arch ldap and multicast test images [release-4.11] Bug 2106942: use multi-arch ldap and multicast test images Jul 13, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jul 13, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 13, 2022

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2106942, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2089966 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Bugzilla bug 2089966 targets the "4.12.0" release, which is one of the valid target releases: 4.12.0
  • bug has dependents

In response to this:

[release-4.11] Bug 2106942: use multi-arch ldap and multicast test images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from adambkaplan and dcbw July 13, 2022 22:37
@openshift-ci openshift-ci bot added the e2e-images-update Related to images used by e2e tests label Jul 13, 2022
@yselkowitz
Copy link
Contributor

This replaces the last two original, manually built, x86-only, and unmaintained test images with multi-arch enabled builds maintained by QE.
/assign @soltysh

soltysh
soltysh approved these changes Jul 14, 2022
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/label backport-risk-assessed
/retest-required

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jul 14, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 14, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 14, 2022
@xingxingxia
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 15, 2022
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 2 against base HEAD b860532 and 8 for PR HEAD 08a004a in total

@yselkowitz
Copy link
Contributor

/retest-required

@yselkowitz
Copy link
Contributor

/test all

@yselkowitz
Copy link
Contributor

/retest

@openshift-merge-robot openshift-merge-robot merged commit dca697b into openshift:release-4.11 Aug 10, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 10, 2022

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 2106942 has been moved to the MODIFIED state.

In response to this:

[release-4.11] Bug 2106942: use multi-arch ldap and multicast test images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 10, 2022

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-single-node 08a004a link false /test e2e-aws-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yselkowitz yselkowitz mentioned this pull request Aug 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@adambkaplan adambkaplan Awaiting requested review from adambkaplan

@dcbw dcbw Awaiting requested review from dcbw

Assignees

@soltysh soltysh

@kasturinarra kasturinarra

@zhouying7780 zhouying7780

@yselkowitz yselkowitz

@xingxingxia xingxingxia

@sunilcio sunilcio

@jitendar-singh jitendar-singh

@prietyc123 prietyc123

@wangke19 wangke19

@gangwgr gangwgr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. e2e-images-update Related to images used by e2e tests lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet