[release-4.11] Bug 2108978: pkg/monitor: wait for Prometheus sidecars to be ready #27313

openshift-cherrypick-robot · 2022-07-20T07:55:45Z

This is an automated cherry-pick of #27224

/assign simonpasquier

When fetching alerts from Thanos Query, we should first ensure that the queriers are connected to all Prometheus sidecars. Otherwise the returned data could have gaps which would fail the tests verifying that the Watchdog alert has been always firing. Signed-off-by: Simon Pasquier <spasquie@redhat.com>

openshift-ci · 2022-07-20T07:56:19Z

@openshift-cherrypick-robot: Bugzilla bug 2079679 has been cloned as Bugzilla bug 2108978. Retitling PR to link against new bug.
/retitle [release-4.11] Bug 2108978: pkg/monitor: wait for Prometheus sidecars to be ready

In response to this:

[release-4.11] Bug 2079679: pkg/monitor: wait for Prometheus sidecars to be ready

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-07-20T07:57:15Z

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2108978, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.11.0) matches configured target release for branch (4.11.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 2079679 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
dependent Bugzilla bug 2079679 targets the "4.12.0" release, which is one of the valid target releases: 4.12.0
bug has dependents

Requesting review from QA contact:
/cc @juzhao

In response to this:

[release-4.11] Bug 2108978: pkg/monitor: wait for Prometheus sidecars to be ready

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

simonpasquier · 2022-07-26T08:00:05Z

/hold

it looks like we're having a following issue which is that the function retrieving the alerts from Thanos receives a canceled context.

https://bugzilla.redhat.com/show_bug.cgi?id=2108192
https://issues.redhat.com/browse/TRT-384

simonpasquier · 2022-07-27T16:21:59Z

/retest

openshift-ci · 2022-07-27T19:59:59Z

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-single-node-upgrade	`fd55920`	link	false	`/test e2e-aws-single-node-upgrade`
ci/prow/e2e-aws-single-node	`fd55920`	link	false	`/test e2e-aws-single-node`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

simonpasquier · 2022-08-08T15:58:02Z

/bugzilla refresh

simonpasquier · 2022-08-08T15:58:13Z

/hold cancel

openshift-ci · 2022-08-08T15:58:25Z

@simonpasquier: This pull request references Bugzilla bug 2108978, which is invalid:

expected the bug to target the "4.11.0" release, but it targets "4.11.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

simonpasquier · 2022-09-12T08:45:48Z

/bugzilla refresh

openshift-ci · 2022-09-12T08:45:55Z

@simonpasquier: This pull request references Bugzilla bug 2108978, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.11.z) matches configured target release for branch (4.11.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 2079679 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 2079679 targets the "4.12.0" release, which is one of the valid target releases: 4.12.0
bug has dependents

Requesting review from QA contact:
/cc @juzhao

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sthaha

/lgtm

simonpasquier · 2022-09-13T07:56:09Z

@bparees could you have a look at this please?

bparees · 2022-09-13T13:19:30Z

/label backport-risk-assessed
/label cherry-pick-approved

openshift-ci · 2022-09-13T13:20:35Z

@bparees: Can not set label backport-risk-assessed: Must be member in one of these teams: []

In response to this:

/label backport-risk-assessed
/label cherry-pick-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-09-13T13:21:05Z

@bparees: Can not set label cherry-pick-approved: Must be member in one of these teams: []

In response to this:

/label backport-risk-assessed
/label cherry-pick-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

juzhao · 2022-09-19T02:31:36Z

/label qe-approved

simonpasquier · 2022-09-27T07:20:37Z

/skip

@bparees sorry to bother you again, would you mind adding the /approve label too?

bparees · 2022-09-27T13:13:43Z

/approve

openshift-ci · 2022-09-27T13:14:22Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, openshift-cherrypick-robot, sthaha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~pkg/OWNERS~~ [bparees]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2022-09-27T15:57:28Z

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

openshift/origin#27313

Bugzilla bug 2108978 has been moved to the MODIFIED state.

In response to this:

[release-4.11] Bug 2108978: pkg/monitor: wait for Prometheus sidecars to be ready

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot mentioned this pull request Jul 20, 2022

Bug 2079679: pkg/monitor: wait for Prometheus sidecars to be ready #27224

Merged

openshift-ci bot assigned simonpasquier Jul 20, 2022

openshift-ci bot changed the title ~~[release-4.11] Bug 2079679: pkg/monitor: wait for Prometheus sidecars to be ready~~ [release-4.11] Bug 2108978: pkg/monitor: wait for Prometheus sidecars to be ready Jul 20, 2022

openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jul 20, 2022

openshift-ci bot requested review from juzhao, csrwng and mfojtik July 20, 2022 07:57

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 26, 2022

openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 12, 2022

sthaha reviewed Sep 13, 2022

View reviewed changes

openshift-ci bot assigned sthaha Sep 13, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2022

bparees added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. labels Sep 13, 2022

openshift-ci bot assigned gangwgr, jitendar-singh, kasturinarra, prietyc123, sunilcio, wangke19, xingxingxia and zhouying7780 Sep 13, 2022

openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Sep 19, 2022

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 27, 2022

openshift-merge-robot merged commit 011cfa5 into openshift:release-4.11 Sep 27, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[release-4.11] Bug 2108978: pkg/monitor: wait for Prometheus sidecars to be ready #27313

[release-4.11] Bug 2108978: pkg/monitor: wait for Prometheus sidecars to be ready #27313

openshift-cherrypick-robot commented Jul 20, 2022

openshift-ci bot commented Jul 20, 2022

openshift-ci bot commented Jul 20, 2022

simonpasquier commented Jul 26, 2022

simonpasquier commented Jul 27, 2022

openshift-ci bot commented Jul 27, 2022

simonpasquier commented Aug 8, 2022

simonpasquier commented Aug 8, 2022

openshift-ci bot commented Aug 8, 2022

simonpasquier commented Sep 12, 2022

openshift-ci bot commented Sep 12, 2022

sthaha left a comment

simonpasquier commented Sep 13, 2022

bparees commented Sep 13, 2022

openshift-ci bot commented Sep 13, 2022

openshift-ci bot commented Sep 13, 2022

juzhao commented Sep 19, 2022

simonpasquier commented Sep 27, 2022

bparees commented Sep 27, 2022

openshift-ci bot commented Sep 27, 2022

openshift-ci bot commented Sep 27, 2022

[release-4.11] Bug 2108978: pkg/monitor: wait for Prometheus sidecars to be ready #27313

[release-4.11] Bug 2108978: pkg/monitor: wait for Prometheus sidecars to be ready #27313

Conversation

openshift-cherrypick-robot commented Jul 20, 2022

openshift-ci bot commented Jul 20, 2022

openshift-ci bot commented Jul 20, 2022

simonpasquier commented Jul 26, 2022

simonpasquier commented Jul 27, 2022

openshift-ci bot commented Jul 27, 2022

simonpasquier commented Aug 8, 2022

simonpasquier commented Aug 8, 2022

openshift-ci bot commented Aug 8, 2022

simonpasquier commented Sep 12, 2022

openshift-ci bot commented Sep 12, 2022

sthaha left a comment

Choose a reason for hiding this comment

simonpasquier commented Sep 13, 2022

bparees commented Sep 13, 2022

openshift-ci bot commented Sep 13, 2022

openshift-ci bot commented Sep 13, 2022

juzhao commented Sep 19, 2022

simonpasquier commented Sep 27, 2022

bparees commented Sep 27, 2022

openshift-ci bot commented Sep 27, 2022

openshift-ci bot commented Sep 27, 2022