Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2106897: Remove oc image info test that uses mysql, aligns with 4.7+ version of this test #27321

Merged
merged 1 commit into from
Jul 27, 2022
Merged

Bug 2106897: Remove oc image info test that uses mysql, aligns with 4.7+ version of this test #27321

merged 1 commit into from
Jul 27, 2022

Conversation

bparees
Copy link
Contributor

@bparees bparees commented Jul 26, 2022

No description provided.

@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 26, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 26, 2022

@bparees: This pull request references Bugzilla bug 2106897, which is invalid:

  • expected the bug to target the "4.6.z" release, but it targets "---" instead
  • expected Bugzilla bug 2106897 to depend on a bug targeting a release in 4.7.0, 4.7.z and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2106897: Remove oc image info test that uses mysql, aligns with 4.7+ version of this test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bparees
Copy link
Contributor Author

bparees commented Jul 26, 2022

@dmage @soltysh ptal

same as what was done in https://github.com/openshift/origin/pull/25744/files for https://bugzilla.redhat.com/show_bug.cgi?id=1904679

@bparees bparees added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 26, 2022
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2022
wking
wking approved these changes Jul 26, 2022
View reviewed changes
Copy link
Member

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@wking wking mentioned this pull request Jul 26, 2022
Merged
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 26, 2022
@bparees
Copy link
Contributor Author

bparees commented Jul 26, 2022

/hold

want to be sure @dmage and @soltysh get a say on this since it's test coverage for their components.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 26, 2022
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 26, 2022
@wking
Copy link
Member

wking commented Jul 26, 2022

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 26, 2022

@wking: This pull request references Bugzilla bug 2106897, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.z) matches configured target release for branch (4.6.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1904679 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1904679 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0, 4.7.z
  • bug has dependents

Requesting review from QA contact:
/cc @xiuwang

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from xiuwang July 26, 2022 19:38
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 26, 2022

@bparees: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

soltysh
soltysh approved these changes Jul 27, 2022
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@soltysh
Copy link
Member

soltysh commented Jul 27, 2022

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jul 27, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 27, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, soltysh, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bparees
Copy link
Contributor Author

bparees commented Jul 27, 2022

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 27, 2022
@bparees bparees added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Jul 27, 2022
@bparees
Copy link
Contributor Author

bparees commented Jul 27, 2022

no QE impact so manually cherry-pick approving

@bparees bparees removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 27, 2022
@openshift-merge-robot openshift-merge-robot merged commit 5d66591 into openshift:release-4.6 Jul 27, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 27, 2022

@bparees: All pull requests linked via external trackers have merged:

Bugzilla bug 2106897 has been moved to the MODIFIED state.

In response to this:

Bug 2106897: Remove oc image info test that uses mysql, aligns with 4.7+ version of this test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gangwgr
Copy link
Contributor

gangwgr commented Jul 27, 2022

/label cherry-pick-approved

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-tests-container-v4.6.0-202311250021.p0.g5d66591.assembly.stream for distgit openshift-enterprise-tests.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wking wking wking approved these changes

@soltysh soltysh soltysh approved these changes

@dmage dmage Awaiting requested review from dmage

@ricardomaraschini ricardomaraschini Awaiting requested review from ricardomaraschini

@xiuwang xiuwang Awaiting requested review from xiuwang

Assignees

@wking wking

@soltysh soltysh

@kasturinarra kasturinarra

@zhouying7780 zhouying7780

@xingxingxia xingxingxia

@sunilcio sunilcio

@jitendar-singh jitendar-singh

@prietyc123 prietyc123

@wangke19 wangke19

@gangwgr gangwgr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet