Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EgressIP: Enable EgressIP tests for OpenStack #27363

Merged
merged 1 commit into from Aug 24, 2022
Merged

EgressIP: Enable EgressIP tests for OpenStack #27363

merged 1 commit into from Aug 24, 2022

Conversation

andreaskaris
Copy link
Contributor

@andreaskaris andreaskaris commented Aug 18, 2022 •
edited

Test with:

./openshift-tests run all --print-commands  | grep EgressIP | grep external | grep -v "Skipped:Network/OVNKubernetes" | while IFS= read -r line; do bash -c "$line" ; echo =========================; done

Signed-off-by: Andreas Karis ak.karis@gmail.com

@andreaskaris
Copy link
Contributor Author

/retest

@danwinship
Copy link
Contributor

/approve
(I'll let someone else lgtm)

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2022
kyrtapz
kyrtapz reviewed Aug 23, 2022
View reviewed changes
test/extended/networking/egressip_helpers.go
if len(ipList) < 64 {
return []string{}, fmt.Errorf("Cloud type is OpenStack, but there are less than 64 IPs available in the IP network %s", ipnetStr)
}
ipList = ipList[len(ipList)-32 : len(ipList)-1]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ipList = ipList[len(ipList)-32 : len(ipList)-1]
ipList = ipList[len(ipList)-32:]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed: https://go.dev/play/p/ACO8G81pV-V

@andreaskaris andreaskaris force-pushed the egressip-openstack branch 2 times, most recently from 6f86139 to 3c1fe4e Compare August 23, 2022 16:26
@andreaskaris
EgressIP: Enable EgressIP tests for OpenStack
3966824 
Signed-off-by: Andreas Karis <ak.karis@gmail.com>
@kyrtapz
Copy link
Contributor

kyrtapz commented Aug 23, 2022

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 23, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreaskaris, danwinship, kyrtapz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2022
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 2 against base HEAD be64bf3 and 8 for PR HEAD 3966824 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 1 against base HEAD be64bf3 and 7 for PR HEAD 3966824 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD be64bf3 and 6 for PR HEAD 3966824 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 24, 2022

@andreaskaris: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-single-node-upgrade 3966824 link false /test e2e-aws-single-node-upgrade
ci/prow/e2e-gcp-ovn-rt-upgrade 3966824 link false /test e2e-gcp-ovn-rt-upgrade
ci/prow/e2e-agnostic-cmd 3966824 link false /test e2e-agnostic-cmd
ci/prow/e2e-metal-ipi-ovn-ipv6 3966824 link false /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-aws-single-node 3966824 link false /test e2e-aws-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 804b1c8 into openshift:master Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyrtapz kyrtapz kyrtapz left review comments

@danwinship danwinship Awaiting requested review from danwinship

@knobunc knobunc Awaiting requested review from knobunc

Assignees

@kyrtapz kyrtapz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@andreaskaris @danwinship @kyrtapz @openshift-ci-robot @openshift-merge-robot