Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USHIFT-354: MicroShift: skip sig-instrumentation tests #27399

Merged
merged 1 commit into from Oct 2, 2022
Merged

USHIFT-354: MicroShift: skip sig-instrumentation tests #27399

merged 1 commit into from Oct 2, 2022

Conversation

pacevedom
Copy link
Contributor

No description provided.

deads2k
deads2k reviewed Sep 6, 2022
View reviewed changes
test/extended/prometheus/prometheus.go Outdated
@@ -71,6 +71,14 @@ var _ = g.Describe("[sig-instrumentation][Late] OpenShift alerting rules", func(
var alertingRules map[string][]promv1.AlertingRule
oc := exutil.NewCLIWithoutNamespace("prometheus")

g.BeforeEach(func() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please enumerate which tests are being skipped and why an apigroup detection or capability detection (do I have a prometheus route) isn't more appropriate.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 8, 2022
@pacevedom
Copy link
Contributor Author

/hold
Need to rework.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 13, 2022
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 13, 2022
@pacevedom
Copy link
Contributor Author

/unhold
Ready for review
/assign @ingvagabund

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 13, 2022
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 23, 2022
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 23, 2022
@ingvagabund
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2022
soltysh
soltysh approved these changes Sep 29, 2022
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 29, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund, pacevedom, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 29, 2022
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e25bd15 and 2 for PR HEAD afd956a in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 8767b07 and 1 for PR HEAD afd956a in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 6c3592b and 0 for PR HEAD afd956a in total

@pacevedom
Copy link
Contributor Author

/retest-required

@openshift-ci-robot
Copy link

/hold

Revision afd956a was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 30, 2022
@pacevedom
Copy link
Contributor Author

/unhold
/retest-required

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 30, 2022
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD ef6536b and 2 for PR HEAD afd956a in total

@pacevedom
Copy link
Contributor Author

/retest-required

2 similar comments
@pacevedom
Copy link
Contributor Author

/retest-required

@pacevedom
Copy link
Contributor Author

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 1, 2022 •
edited

@pacevedom: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agnostic-ovn-cmd afd956a link false /test e2e-agnostic-ovn-cmd
ci/prow/e2e-aws-ovn-single-node-serial afd956a link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-gcp-ovn-rt-upgrade afd956a link false /test e2e-gcp-ovn-rt-upgrade
ci/prow/e2e-aws-ovn-single-node afd956a link false /test e2e-aws-ovn-single-node
ci/prow/e2e-aws-ovn-single-node-upgrade afd956a link false /test e2e-aws-ovn-single-node-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pacevedom
Copy link
Contributor Author

/retest-required

@openshift-merge-robot openshift-merge-robot merged commit 1000ea0 into openshift:master Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k deads2k left review comments

@soltysh soltysh soltysh approved these changes

@mfojtik mfojtik Awaiting requested review from mfojtik

@simonpasquier simonpasquier Awaiting requested review from simonpasquier

Assignees

@ingvagabund ingvagabund

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@pacevedom @ingvagabund @openshift-ci-robot @soltysh @deads2k @openshift-merge-robot