Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more resource to watch #27514

Merged
merged 1 commit into from Nov 3, 2022

Conversation

xueqzhan
Copy link
Contributor

@xueqzhan xueqzhan commented Nov 1, 2022

This is mainly port of code from https://github.com/dgoodwin/origin/tree/observer-rw to add more resources to watch.

TRT-469

@xueqzhan
Copy link
Contributor Author

xueqzhan commented Nov 2, 2022

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 2, 2022

@xueqzhan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node-serial b0bda91 link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-aws-ovn-single-node-upgrade b0bda91 link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-gcp-ovn-rt-upgrade b0bda91 link false /test e2e-gcp-ovn-rt-upgrade
ci/prow/e2e-openstack-ovn b0bda91 link false /test e2e-openstack-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dgoodwin
Copy link
Contributor

dgoodwin commented Nov 2, 2022

I need this functionality asap but I'd like to be able to see it work, however i don't see any presubmits the observer is wired up to. Ken is there a non-aggregated job we could run payload-job command against?

@xueqzhan
Copy link
Contributor Author

xueqzhan commented Nov 2, 2022

/payload-job periodic-ci-openshift-release-master-nightly-4.12-e2e-metal-ipi-ovn-ipv6

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 2, 2022

@xueqzhan: trigger 1 job(s) for the /payload-(job|aggregate) command

  • periodic-ci-openshift-release-master-nightly-4.12-e2e-metal-ipi-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/adf5a870-5abd-11ed-963e-f79e7993f413-0

@xueqzhan
Copy link
Contributor Author

xueqzhan commented Nov 2, 2022

I need this functionality asap but I'd like to be able to see it work, however i don't see any presubmits the observer is wired up to. Ken is there a non-aggregated job we could run payload-job command against?

I just ran a job. Hopefully you will get it within three hours.

Well, it says "2022-11-02 14:50:57 +0000 UTC: AllJobsTriggered: WithErrors: Jobs triggered with errors". I wonder why.

@xueqzhan
Copy link
Contributor Author

xueqzhan commented Nov 2, 2022

/payload-job periodic-ci-openshift-release-master-nightly-4.12-e2e-aws-sdn-serial

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 2, 2022

@xueqzhan: trigger 1 job(s) for the /payload-(job|aggregate) command

  • periodic-ci-openshift-release-master-nightly-4.12-e2e-aws-sdn-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/7bac7820-5abe-11ed-93ec-58f48eb13ff0-0

@dgoodwin
Copy link
Contributor

dgoodwin commented Nov 2, 2022

can't get results to see if this is working here, but Ken is confident it's good to go.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 2, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 2, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin, xueqzhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2022
@xueqzhan
Copy link
Contributor Author

xueqzhan commented Nov 2, 2022

/retest-required

@openshift-merge-robot openshift-merge-robot merged commit 9ad6ff9 into openshift:master Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants