Change disruption threshold to minimize noises #27674
Conversation
| // allow a little over 10% when the number is big, while keep a minimum of 10s while the number is | ||
| // small. | ||
| func getRoundedAllowedDisruption(allowedDisruption time.Duration) time.Duration { | ||
| return (allowedDisruption*11/10 + 10).Round(time.Second) |
There was a problem hiding this comment.
Suggest allowedDisruption*1.1 + 10 for clarity.
There was a problem hiding this comment.
allowedDisruption is time.Duration. So this suggestion does not work. I am not sure it will be as clear as we hope if I add some cast to make it work. Maybe allowedDisruption*110/100 + 10?
There was a problem hiding this comment.
Ok no worries then, lets just leave as is, we all had a good look this morning.
|
I'm going to approve this, we didn't totally decide that this morning but I think it's time. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgoodwin, xueqzhan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@xueqzhan: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/hold Changed plan, want to hold this consistent while we try to land RHCOS and 1.26 rebase. |
openshift-ci
bot
added
the
do-not-merge/hold
|
Job Failure Risk Analysis for sha: efa7ed6
|
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci
bot
added
the
lifecycle/stale
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
openshift-ci
bot
added
lifecycle/rotten
|
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@openshift-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
TRT-786