Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.12] OCPBUGS-8024: Backport fixes to resume gathering CI disruption data for SLB and image registry #27759

Merged
merged 3 commits into from Mar 1, 2023
Merged

[release-4.12] OCPBUGS-8024: Backport fixes to resume gathering CI disruption data for SLB and image registry #27759

merged 3 commits into from Mar 1, 2023

Conversation

dgoodwin
Copy link
Contributor

@dgoodwin dgoodwin commented Feb 28, 2023 •
edited by openshift-ci bot

These fixes were applied in 4.13 early this year, but the backport was missed, as such we are not gathering SLB or image registry disruption numbers in 4.12.

No product changes, just CI data gathering.

TRT-825

@dgoodwin
Fix missing disruption uploads.
ed21280 
Discovered that we are getting no data for image registry since Dec 7th
due to PR openshift#27574 which shut off the entire monitor if we have less than
the required 100 runs to appear in the file of allowances to enforce. I
guess at this time, we did not have enough runs with image registry for
4.13. (which is unusual)

Skip the test, but let the monitor run.
@dgoodwin
Fix missing disruption data again.
7c7d2e2 
Previous attempt did not work, as we were still bypassing
FrameworkEventIntervals() which is needed to add the test summary, which
eventually results in the AdditionalEvents json files in artifacts,
which are then merged into the overall events and disruption data files.
Without calling it, we still get no disruption data uploaded.

Move the nil check into the ExpectNoDisruption function, and allow
FrameworkEventIntervals to run as it should.
@dgoodwin
Add logging for the job type we determined
ccca62d
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 28, 2023

@dgoodwin: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.12] OCPBUGS-8024: Backport fixes to resume gathering CI disruption data for SLB and image registry

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 28, 2023
@openshift-ci-robot
Copy link

@dgoodwin: This pull request references Jira Issue OCPBUGS-8024, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

These fixes were applied in 4.13 early this year, but the backport was missed, as such we are not gathering SLB or image registry disruption numbers in 4.12.

No product changes, just CI data gathering.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2023
@dgoodwin
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 28, 2023
@openshift-ci-robot
Copy link

@dgoodwin: This pull request references Jira Issue OCPBUGS-8024, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.z) matches configured target version for branch (4.12.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-8022 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-8022 targets the "4.13.0" version, which is one of the valid target versions: 4.13.0
  • bug has dependents

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xueqzhan
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin, xueqzhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 28, 2023 •
edited by openshift-ci bot

@dgoodwin: This pull request references Jira Issue OCPBUGS-8024, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.z) matches configured target version for branch (4.12.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-8022 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-8022 targets the "4.13.0" version, which is one of the valid target versions: 4.13.0
  • bug has dependents

In response to this:

These fixes were applied in 4.13 early this year, but the backport was missed, as such we are not gathering SLB or image registry disruption numbers in 4.12.

No product changes, just CI data gathering.

TRT-825

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 28, 2023

@dgoodwin: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Retaining the bugzilla/valid-bug label as it was manually added.

In response to this:

[release-4.12] OCPBUGS-8024: Backport fixes to resume gathering CI disruption data for SLB and image registry

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@dgoodwin: This pull request references Jira Issue OCPBUGS-8024, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.z) matches configured target version for branch (4.12.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-8022 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-8022 targets the "4.13.0" version, which is one of the valid target versions: 4.13.0
  • bug has dependents

In response to this:

These fixes were applied in 4.13 early this year, but the backport was missed, as such we are not gathering SLB or image registry disruption numbers in 4.12.

No product changes, just CI data gathering.

TRT-825

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 28, 2023

@dgoodwin: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Retaining the bugzilla/valid-bug label as it was manually added.

In response to this:

[release-4.12] OCPBUGS-8024: Backport fixes to resume gathering CI disruption data for SLB and image registry

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@deads2k deads2k added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. labels Feb 28, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 4262632 and 2 for PR HEAD ccca62d in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 28, 2023 •
edited

@dgoodwin: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-serial-ovn-ipv6 ccca62d link false /test e2e-metal-ipi-serial-ovn-ipv6
ci/prow/e2e-aws-ovn-upgrade ccca62d link false /test e2e-aws-ovn-upgrade
ci/prow/e2e-aws-ovn-single-node-serial ccca62d link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-agnostic-ovn-cmd ccca62d link false /test e2e-agnostic-ovn-cmd
ci/prow/e2e-aws-ovn-cgroupsv2 ccca62d link false /test e2e-aws-ovn-cgroupsv2
ci/prow/e2e-aws-ovn-single-node-upgrade ccca62d link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-vsphere-ovn-etcd-scaling ccca62d link false /test e2e-vsphere-ovn-etcd-scaling
ci/prow/e2e-azure-ovn-etcd-scaling ccca62d link false /test e2e-azure-ovn-etcd-scaling
ci/prow/e2e-aws-csi ccca62d link false /test e2e-aws-csi
ci/prow/e2e-aws-ovn-etcd-scaling ccca62d link false /test e2e-aws-ovn-etcd-scaling

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dgoodwin
Copy link
Contributor Author

dgoodwin commented Mar 1, 2023

/test e2e-aws-ovn-serial

@openshift-merge-robot openshift-merge-robot merged commit 76791c0 into openshift:release-4.12 Mar 1, 2023
@openshift-ci-robot
Copy link

@dgoodwin: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-8024 has been moved to the MODIFIED state.

In response to this:

These fixes were applied in 4.13 early this year, but the backport was missed, as such we are not gathering SLB or image registry disruption numbers in 4.12.

No product changes, just CI data gathering.

TRT-825

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER] (beta)

This PR has been included in build 2398560 for distgit openshift-enterprise-tests.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@dgoodwin dgoodwin

@stbenjam stbenjam

@kasturinarra kasturinarra

@jadhaj jadhaj

@sunilcio sunilcio

@xueqzhan xueqzhan

@pamoedom pamoedom

@jitendar-singh jitendar-singh

@prietyc123 prietyc123

@gangwgr gangwgr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet