Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ETCD-399: Restore Test - Create scaffolding for platform agnostic ssh… #27799

Merged
merged 1 commit into from Apr 12, 2023
Merged

ETCD-399: Restore Test - Create scaffolding for platform agnostic ssh… #27799

merged 1 commit into from Apr 12, 2023

Conversation

tjungblu
Copy link
Contributor

@tjungblu tjungblu commented Mar 15, 2023 •
edited

… access

This adds a DS that installs ssh keys, stored in a secret in the openshift-etcd-operator namespace.

/hold

for further review by Haseeb.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 15, 2023 •
edited by openshift-ci bot

@tjungblu: This pull request references ETCD-399 which is a valid jira issue.

In response to this:

… access

This adds a DS that installs ssh keys, stored in a secret in the openshift-etcd-operator namespace.

/hold

need to still figure out the testing of the utility itself

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 15, 2023
@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 15, 2023
@openshift-ci openshift-ci bot requested review from celebdor and mfojtik March 15, 2023 12:36
@tjungblu
Copy link
Contributor Author

/retest

@tjungblu
Copy link
Contributor Author

/retest-required

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 20, 2023 •
edited by openshift-ci bot

@tjungblu: This pull request references ETCD-399 which is a valid jira issue.

In response to this:

… access

This adds a DS that installs ssh keys, stored in a secret in the openshift-etcd-operator namespace.

/hold

for further review by Haseeb.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tjungblu
Copy link
Contributor Author

/label tide/merge-method-squash

@openshift-ci openshift-ci bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Mar 22, 2023
@tjungblu
Copy link
Contributor Author

/unlabel tide/merge-method-squash

@tjungblu
Copy link
Contributor Author

/remove tide/merge-method-squash

@tjungblu
Copy link
Contributor Author

/remove-label tide/merge-method-squash

@openshift-ci openshift-ci bot removed the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Mar 22, 2023
@tjungblu
Copy link
Contributor Author

/retest-required

@tjungblu
Copy link
Contributor Author

/retest

@tjungblu
Copy link
Contributor Author

/label tide/merge-method-squash

@openshift-ci openshift-ci bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Mar 23, 2023
@tjungblu
Copy link
Contributor Author

/retest

@tjungblu
Copy link
Contributor Author

/test e2e-aws-ovn-etcd-scaling

@tjungblu
Copy link
Contributor Author

/retest

4 similar comments
@tjungblu
Copy link
Contributor Author

/retest

@tjungblu
Copy link
Contributor Author

/retest

@tjungblu
Copy link
Contributor Author

/retest

@tjungblu
Copy link
Contributor Author

/retest

@hasbro17
Copy link
Contributor

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD d64f5ed and 1 for PR HEAD b4a7bd7 in total

@hasbro17
Copy link
Contributor

/test e2e-aws-ovn-serial

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 4c4f855 and 0 for PR HEAD b4a7bd7 in total

@openshift-ci-robot
Copy link

/hold

Revision b4a7bd7 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 1, 2023
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 10, 2023
@tjungblu
ETCD-399: Create scaffolding for platform agnostic ssh access
7ea85bf 
This adds a DS that installs ssh keys, stored in a secret in the
openshift-etcd-operator namespace and a pod to test access.
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 11, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 11, 2023
@tjungblu
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 11, 2023
@tjungblu
Copy link
Contributor Author

/retest-required

2 similar comments
@tjungblu
Copy link
Contributor Author

/retest-required

@tjungblu
Copy link
Contributor Author

/retest-required

@hasbro17
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 11, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, hasbro17, tjungblu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tjungblu
Copy link
Contributor Author

@bparees could you kindly override the remaining jobs that are not even running? I gotta leave for today.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 4ddb99f and 2 for PR HEAD 7ea85bf in total

@bparees
Copy link
Contributor

bparees commented Apr 11, 2023

@bparees could you kindly override the remaining jobs that are not even running? I gotta leave for today.

https://docs.ci.openshift.org/docs/how-tos/overriding-failing-ci-jobs/#things-to-do-before-applying-an-override covers our steps to take before overriding/asking for overrides

Do you have an example of the failing jobs in question that shows they passed your new test logic even if the overall job failed, in order to complete item (3) from that list?

I see some passes from around march 31st on gcp but i'm not sure if you've evolved the PR since then.

i do not want to override those jobs and then discover your new ssh key distribution logic fails on, for example, gcp, for some unanticipated reason and block everyone's merges.

@tjungblu
Copy link
Contributor Author

/retest-required

@tjungblu
Copy link
Contributor Author

@bparees this test doesn't even run in this test suite, how could this have any impact?

@tjungblu
Copy link
Contributor Author

/retest-required

@tjungblu
Copy link
Contributor Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit c30d0ea into openshift:master Apr 12, 2023
20 of 27 checks passed
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 12, 2023

@tjungblu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-disruptive 43ec816 link false /test e2e-aws-disruptive
ci/prow/e2e-aws-ovn-single-node-serial 7ea85bf link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-openstack-ovn 7ea85bf link false /test e2e-openstack-ovn
ci/prow/e2e-gcp-ovn-etcd-scaling 7ea85bf link false /test e2e-gcp-ovn-etcd-scaling
ci/prow/e2e-vsphere-ovn-etcd-scaling 7ea85bf link false /test e2e-vsphere-ovn-etcd-scaling

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tjungblu tjungblu deleted the sshkeyinst branch April 12, 2023 13:04
@bparees
Copy link
Contributor

bparees commented Apr 12, 2023

@bparees this test doesn't even run in this test suite, how could this have any impact?

sorry i missed that this test has an explicitly defined suite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bparees bparees bparees left review comments

@hasbro17 hasbro17 hasbro17 left review comments

Assignees

@hasbro17 hasbro17

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tjungblu @openshift-ci-robot @hasbro17 @bparees @openshift-merge-robot